Skip to content

Commit 6776ade

Browse files
authored
FIX RUNNER #100 - Streamable ingestion logs to log versions (#24891)
* FIX RUNNER #100 - Streamable ingestion logs to log versions * lazy init
1 parent e71715a commit 6776ade

2 files changed

Lines changed: 22 additions & 6 deletions

File tree

ingestion/src/metadata/ingestion/ometa/mixins/server_mixin.py

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,24 @@ class OMetaServerMixin:
4949

5050
client: REST
5151

52+
@property
53+
def server_version(self) -> str:
54+
"""
55+
Server version property
56+
"""
57+
if not hasattr(self, "_server_version") or self._server_version is None:
58+
self._server_version = self.get_server_version()
59+
return self._server_version
60+
61+
@property
62+
def client_version(self) -> str:
63+
"""
64+
Client version property
65+
"""
66+
if not hasattr(self, "_client_version") or self._client_version is None:
67+
self._client_version = get_client_version()
68+
return self._client_version
69+
5270
def get_server_version(self) -> str:
5371
"""
5472
Run endpoint /system/version to check server version
@@ -68,16 +86,13 @@ def validate_versions(self) -> None:
6886
Validate Server & Client versions. They should match.
6987
Otherwise, raise VersionMismatchException
7088
"""
71-
server_version = self.get_server_version()
72-
client_version = get_client_version()
73-
7489
logger.info(
75-
f"OpenMetadata client running with Server version [{server_version}] and Client version [{client_version}]"
90+
f"OpenMetadata client running with Server version [{self.server_version}] and Client version [{self.client_version}]"
7691
)
7792

78-
if not match_versions(server_version, client_version):
93+
if not match_versions(self.server_version, self.client_version):
7994
raise VersionMismatchException(
80-
f"Server version is {server_version} vs. Client version {client_version}."
95+
f"Server version is {self.server_version} vs. Client version {self.client_version}."
8196
f" Major and minor versions should match."
8297
)
8398

ingestion/src/metadata/utils/streamable_logger.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -553,6 +553,7 @@ def setup_streamable_logging_for_workflow(
553553
logger.info(
554554
f"Streamable logging configured for pipeline: {pipeline_fqn}, run_id: {model_str(run_id)}"
555555
)
556+
metadata.validate_versions() # Send the version check log
556557

557558
return handler
558559

0 commit comments

Comments
 (0)