ISSUE #27718 - make data type required for OpenMetadata test types (#27721)

* fix: make data type required for OpenMetadata test types

* Update openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/DataQuality/TestLibrary.spec.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* chore: fix failing playwright tests

* chore: ran typescript linting

* chore: fix test library playwright failure

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: TeddyCr

openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/DataQuality/TestLibrary.spec.ts

@@ -111,6 +111,15 @@ test.describe(
           .first()
           .click();
 
+        // Select supported data types (required when OpenMetadata platform is selected)
+        await page.locator('#supportedDataTypes').click();
+        await page.locator('#supportedDataTypes').fill('NUMBER');
+        await page
+          .locator('.ant-select-dropdown:visible')
+          .getByTitle('NUMBER')
+          .click();
+        await page.keyboard.press('Escape');
+
         // Select test platform
         await page.locator('#testPlatforms').click();
         await page
@@ -285,6 +294,105 @@ test.describe(
       ).toBeVisible();
     });
 
+    test('should require supported data types only when OpenMetadata platform is selected', async ({
+      page,
+    }) => {
+      test.slow();
+      let createdTestDefinitionId: string | undefined;
+
+      try {
+        await test.step('Open create form', async () => {
+          await page.goto('/test-library');
+          await page.getByTestId('add-test-definition-button').click();
+          await page.locator('.ant-drawer').waitFor({ state: 'visible' });
+        });
+
+        await test.step('Verify supported data types is required with default OpenMetadata platform', async () => {
+          // Fill required fields except supportedDataTypes
+          await page.locator('#name').fill(`validation-test-${uuid()}`);
+          await page.locator('#entityType').click();
+          await page
+            .locator('.ant-select-dropdown:visible')
+            .locator('.ant-select-item-option-content:has-text("TABLE")')
+            .first()
+            .click();
+
+          // Wait for entity type dropdown to close before submitting
+          await expect(
+            page.locator('.ant-select-dropdown:visible')
+          ).not.toBeVisible();
+
+          // Submit the form
+          await page.getByTestId('save-test-definition').click();
+
+          // Expect validation error on supportedDataTypes
+          const supportedDataTypesItem = page
+            .locator('.ant-form-item')
+            .filter({ hasText: 'Supported Data Types' });
+
+          await expect(
+            supportedDataTypesItem.locator('.ant-form-item-explain-error')
+          ).toBeVisible();
+        });
+
+        await test.step('Remove OpenMetadata and select only dbt — field should not be required', async () => {
+          // Remove OpenMetadata from testPlatforms
+          const testPlatformsSelector = page
+            .locator('.ant-form-item')
+            .filter({ hasText: 'Test Platforms' })
+            .locator('.ant-select');
+          const openMetadataTag = testPlatformsSelector.locator(
+            '.ant-select-selection-item[title="OpenMetadata"] .ant-select-selection-item-remove'
+          );
+          await openMetadataTag.click();
+
+          // Add dbt
+          await page.locator('#testPlatforms').click();
+          await page
+            .locator('.ant-select-dropdown:visible')
+            .locator('.ant-select-item-option-content:has-text("dbt")')
+            .first()
+            .click();
+
+          // Close dropdown
+          await page.keyboard.press('Escape');
+
+          // Wait for the validation error to clear after removing OpenMetadata
+          const supportedDataTypesItem = page
+            .locator('.ant-form-item')
+            .filter({ hasText: 'Supported Data Types' });
+          await expect(
+            supportedDataTypesItem.locator('.ant-form-item-explain-error')
+          ).not.toBeVisible();
+
+          // Submit the form — supportedDataTypes should no longer block submission
+          const testDefinitionResponse = page.waitForResponse(
+            (response) =>
+              response.url().includes('/api/v1/dataQuality/testDefinitions') &&
+              response.request().method() === 'POST'
+          );
+          await page.getByTestId('save-test-definition').click();
+
+          const responseData = await testDefinitionResponse;
+          expect(responseData.status()).toBe(201);
+
+          const responseBody = await responseData.json();
+          createdTestDefinitionId = responseBody.id;
+
+          await expect(page.getByText(/created successfully/i)).toBeVisible();
+        });
+      } finally {
+        if (createdTestDefinitionId) {
+          const { apiContext } = await getApiContext(page);
+          const deleteResponse = await apiContext.delete(
+            `/api/v1/dataQuality/testDefinitions/${createdTestDefinitionId}`
+          );
+
+          expect(deleteResponse.ok()).toBeTruthy();
+        }
+      }
+    });
+
     test('should cancel form and close drawer', async ({ page }) => {
       // Navigate to Test Library
       await page.goto('/test-library');
@@ -667,6 +775,15 @@ test.describe(
           page.locator('.ant-select-dropdown:visible')
         ).not.toBeVisible();
 
+        // Select supported data types (required when OpenMetadata platform is selected)
+        await page.locator('#supportedDataTypes').click();
+        await page.locator('#supportedDataTypes').fill('NUMBER');
+        await page
+          .locator('.ant-select-dropdown:visible')
+          .getByTitle('NUMBER')
+          .click();
+        await page.keyboard.press('Escape');
+
         await page.locator('#supportedServices').click();
         await page.locator('#supportedServices').fill('Mysql');
         const mysqlOption = page
@@ -966,6 +1083,15 @@ test.describe(
           page.locator('.ant-select-dropdown:visible')
         ).not.toBeVisible();
 
+        // Select supported data types (required when OpenMetadata platform is selected)
+        await page.locator('#supportedDataTypes').click();
+        await page.locator('#supportedDataTypes').fill('NUMBER');
+        await page
+          .locator('.ant-select-dropdown:visible')
+          .getByTitle('NUMBER')
+          .click();
+        await page.keyboard.press('Escape');
+
         const createResponse = page.waitForResponse(
           (response) =>
             response.url().includes('/api/v1/dataQuality/testDefinitions') &&

openmetadata-ui/src/main/resources/ui/src/components/TestLibrary/TestDefinitionForm/TestDefinitionForm.component.tsx

@@ -12,7 +12,17 @@
  */
 
 import { MinusCircleOutlined, PlusOutlined } from '@ant-design/icons';
-import { Button, Card, Drawer, Form, Input, Select, Space, Switch } from 'antd';
+import {
+  Button,
+  Card,
+  Drawer,
+  Form,
+  FormInstance,
+  Input,
+  Select,
+  Space,
+  Switch,
+} from 'antd';
 import { AxiosError } from 'axios';
 import { compare } from 'fast-json-patch';
 import React, { useMemo, useState } from 'react';
@@ -345,8 +355,19 @@ const TestDefinitionForm: React.FC<TestDefinitionFormProps> = ({
         </Form.Item>
 
         <Form.Item
+          dependencies={['testPlatforms']}
           label={t('label.supported-data-type-plural')}
-          name="supportedDataTypes">
+          name="supportedDataTypes"
+          rules={[
+            ({ getFieldValue }: Pick<FormInstance, 'getFieldValue'>) => ({
+              required: (getFieldValue('testPlatforms') ?? []).includes(
+                TestPlatform.OpenMetadata
+              ),
+              message: t('message.field-text-is-required', {
+                fieldText: t('label.supported-data-type-plural'),
+              }),
+            }),
+          ]}>
           <Select
             disabled={isReadOnlyField}
             mode="multiple"