Commit 2cd827d
authored
fix(playwright): stabilize TagSuggestion select + scope tag-chip assertions (#27811)
* fix(playwright): stabilize TagSuggestion select + scope tag-chip assertions
- selectTagInTagSuggestion now resolves the listbox via the combobox's
aria-controls attribute instead of grabbing the first [role="listbox"]
on the page, which races with stale dropdowns left open by previous
combobox interactions and caused click() to hang until test timeout.
- Scope post-select assertions to tags-container so they no longer match
the still-rendered dropdown option in addition to the chip, which was
triggering strict-mode violations.
- DataProducts spec now dismisses the domain dropdown before opening the
tags dropdown so the two listboxes don't overlap.
* fix(playwright): simplify selectTagInTagSuggestion to anchor on tag-option testId
Drop the listbox/aria-controls indirection in favour of the unique
tag-option-${fqn} testId. click()'s actionability check covers what the
explicit visibility/scroll waits were doing, and tag option testIds are
unique across comboboxes so listbox scoping wasn't pulling its weight.1 parent 5b935df commit 2cd827d
3 files changed
Lines changed: 20 additions & 7 deletions
File tree
- openmetadata-ui/src/main/resources/ui/playwright
- e2e/Pages
- utils
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
479 | 479 | | |
480 | 480 | | |
481 | 481 | | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
482 | 487 | | |
483 | 488 | | |
484 | 489 | | |
| |||
488 | 493 | | |
489 | 494 | | |
490 | 495 | | |
491 | | - | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
492 | 500 | | |
493 | 501 | | |
494 | 502 | | |
| |||
Lines changed: 8 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1167 | 1167 | | |
1168 | 1168 | | |
1169 | 1169 | | |
1170 | | - | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
| 1173 | + | |
1171 | 1174 | | |
1172 | 1175 | | |
1173 | 1176 | | |
| |||
1219 | 1222 | | |
1220 | 1223 | | |
1221 | 1224 | | |
1222 | | - | |
| 1225 | + | |
| 1226 | + | |
| 1227 | + | |
| 1228 | + | |
1223 | 1229 | | |
1224 | 1230 | | |
1225 | 1231 | | |
| |||
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
616 | 616 | | |
617 | 617 | | |
618 | 618 | | |
| 619 | + | |
619 | 620 | | |
620 | 621 | | |
621 | 622 | | |
| |||
626 | 627 | | |
627 | 628 | | |
628 | 629 | | |
| 630 | + | |
629 | 631 | | |
630 | 632 | | |
631 | 633 | | |
632 | | - | |
633 | | - | |
634 | | - | |
635 | 634 | | |
636 | 635 | | |
637 | | - | |
| 636 | + | |
638 | 637 | | |
0 commit comments