Skip to content

Commit 2352a2c

Browse files
committed
Fixed flaky entity data steward spec (#27829)
1 parent 63ae7a4 commit 2352a2c

1 file changed

Lines changed: 30 additions & 4 deletions

File tree

  • openmetadata-ui/src/main/resources/ui/playwright/utils

openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts

Lines changed: 30 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -898,6 +898,12 @@ export const removeTag = async (page: Page, tags: string[]) => {
898898
await page.getByTestId('saveAssociatedTag').click();
899899
await patchRequest;
900900

901+
await page
902+
.getByTestId('saveAssociatedTag')
903+
.locator('[data-icon="loading"]')
904+
.waitFor({ state: 'detached' });
905+
await expect(page.getByTestId('saveAssociatedTag')).not.toBeVisible();
906+
901907
await expect(
902908
page
903909
.getByTestId('KnowledgePanel.Tags')
@@ -954,6 +960,12 @@ export const removeTagsFromChildren = async ({
954960

955961
await patchRequest;
956962

963+
await page
964+
.getByTestId('saveAssociatedTag')
965+
.locator('[data-icon="loading"]')
966+
.waitFor({ state: 'detached' });
967+
await expect(page.getByTestId('saveAssociatedTag')).not.toBeVisible();
968+
957969
await expect(
958970
page
959971
.locator(`[${rowSelector}="${rowId}"]`)
@@ -1007,9 +1019,11 @@ export const assignGlossaryTerm = async (
10071019
.click();
10081020

10091021
await patchRequest;
1010-
await expect(
1011-
page.getByTestId('custom-drop-down-menu').getByTestId('saveAssociatedTag')
1012-
).not.toBeVisible();
1022+
await page
1023+
.getByTestId('saveAssociatedTag')
1024+
.locator('[data-icon="loading"]')
1025+
.waitFor({ state: 'detached' });
1026+
await expect(page.getByTestId('saveAssociatedTag')).not.toBeVisible();
10131027

10141028
await expect(
10151029
page
@@ -1238,6 +1252,12 @@ export const removeGlossaryTerm = async (
12381252
.click();
12391253
await patchRequest;
12401254

1255+
await page
1256+
.getByTestId('saveAssociatedTag')
1257+
.locator('[data-icon="loading"]')
1258+
.waitFor({ state: 'detached' });
1259+
await expect(page.getByTestId('saveAssociatedTag')).not.toBeVisible();
1260+
12411261
await expect(
12421262
page
12431263
.getByTestId('KnowledgePanel.GlossaryTerms')
@@ -1296,7 +1316,13 @@ export const removeGlossaryTermFromChildren = async ({
12961316

12971317
await patchRequest;
12981318

1299-
expect(
1319+
await page
1320+
.getByTestId('saveAssociatedTag')
1321+
.locator('[data-icon="loading"]')
1322+
.waitFor({ state: 'detached' });
1323+
await expect(page.getByTestId('saveAssociatedTag')).not.toBeVisible();
1324+
1325+
await expect(
13001326
page
13011327
.locator(`[${rowSelector}="${rowId}"]`)
13021328
.getByTestId('glossary-container')

0 commit comments

Comments
 (0)