From 98b11fd9b1612041019e4544d9033bb2315e45c0 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 4 Sep 2026 14:10:23 +0000 Subject: [PATCH] test(metadata): delete the eight always-true `if (manager.X)` guards so the assertions actually run MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Every assertion in `metadata-history.test.ts` sat inside a truthiness guard over the very method under test — `if (manager.getHistory)`, `if (manager.rollback)`, `if (manager.diff)` — at :47 :81 :111 :146 :167 :197 :207 :222, one per `it()`, eight guards over eight tests. All three are UNCONDITIONAL members of `MetadataManager` (`metadata-manager.ts` :3105 `async getHistory(`, :3129 `async rollback(`, :3179 `async diff(`), so each guard is always true and buys nothing — while making every assertion structurally optional. Rename or retire one of the three and the guard goes false, the block is skipped, the `it()` finishes asserting nothing, and the suite reports GREEN. A test that stops testing looked identical to one that passes. Measured rather than argued, by a paired ablation on the METHOD (rename `async diff(` out of `MetadataManager`, mutation confirmed on disk by grep counts of the vanished anchor and an injected marker, restored under a trap and proven against the path's HEAD blob hash plus an empty `git diff HEAD`): with the guards present → vitest GREEN, 8 passed, exit 0 (the silent skip) with the guards deleted → vitest RED (see PR body) Only the guards and their braces are removed; the bodies are de-indented and NO assertion is rewritten — the `patch!` non-null at the old :150 is carried through verbatim. 228 lines to 212, 8 `it()` blocks and 20 `expect(` calls before and after. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01ARYe3yQTQCUFm5qPYNgKaJ --- .../metadata/src/metadata-history.test.ts | 90 ++++++++----------- 1 file changed, 37 insertions(+), 53 deletions(-) diff --git a/packages/metadata/src/metadata-history.test.ts b/packages/metadata/src/metadata-history.test.ts index 404a3a499a..35b95c84f7 100644 --- a/packages/metadata/src/metadata-history.test.ts +++ b/packages/metadata/src/metadata-history.test.ts @@ -44,13 +44,11 @@ describe('Metadata History', () => { await manager.register('object', 'test_object', objectDef); // Check that history was created - if (manager.getHistory) { - const history = await manager.getHistory('object', 'test_object'); + const history = await manager.getHistory('object', 'test_object'); - expect(history.records.length).toBeGreaterThan(0); - expect(history.records[0].operationType).toBe('create'); - expect(history.records[0].version).toBe(1); - } + expect(history.records.length).toBeGreaterThan(0); + expect(history.records[0].operationType).toBe('create'); + expect(history.records[0].version).toBe(1); }); it('should create history record on metadata update', async () => { @@ -78,13 +76,11 @@ describe('Metadata History', () => { await manager.register('object', 'test_object', updatedDef); // Check history - if (manager.getHistory) { - const history = await manager.getHistory('object', 'test_object'); + const history = await manager.getHistory('object', 'test_object'); - expect(history.records.length).toBeGreaterThanOrEqual(2); - expect(history.records[0].operationType).toBe('update'); - expect(history.records[0].version).toBe(2); - } + expect(history.records.length).toBeGreaterThanOrEqual(2); + expect(history.records[0].operationType).toBe('update'); + expect(history.records[0].version).toBe(2); }); it('should rollback to previous version', async () => { @@ -108,12 +104,10 @@ describe('Metadata History', () => { await manager.register('object', 'test_object', version2); // Rollback to version 1 - if (manager.rollback) { - const restored = await manager.rollback('object', 'test_object', 1); + const restored = await manager.rollback('object', 'test_object', 1); - expect(restored).toBeDefined(); - expect((restored as any).label).toBe('Version 1'); - } + expect(restored).toBeDefined(); + expect((restored as any).label).toBe('Version 1'); // Verify current metadata is version 1 const current = await manager.get('object', 'test_object'); @@ -143,13 +137,11 @@ describe('Metadata History', () => { await manager.register('object', 'test_object', version2); // Compare versions - if (manager.diff) { - const diffResult = await manager.diff('object', 'test_object', 1, 2); + const diffResult = await manager.diff('object', 'test_object', 1, 2); - expect(diffResult.identical).toBe(false); - expect(diffResult.patch!.length).toBeGreaterThan(0); - expect(diffResult.summary).toContain('modified'); - } + expect(diffResult.identical).toBe(false); + expect(diffResult.patch!.length).toBeGreaterThan(0); + expect(diffResult.summary).toContain('modified'); }); it('should handle history query with filters', async () => { @@ -164,22 +156,20 @@ describe('Metadata History', () => { await new Promise(resolve => setTimeout(resolve, 10)); } - if (manager.getHistory) { - // Query with limit - const limitedHistory = await manager.getHistory('object', 'test_object', { - limit: 3, - }); + // Query with limit + const limitedHistory = await manager.getHistory('object', 'test_object', { + limit: 3, + }); - expect(limitedHistory.records.length).toBeLessThanOrEqual(3); - expect(limitedHistory.total).toBeGreaterThanOrEqual(5); + expect(limitedHistory.records.length).toBeLessThanOrEqual(3); + expect(limitedHistory.total).toBeGreaterThanOrEqual(5); - // Query with operation type filter - const createHistory = await manager.getHistory('object', 'test_object', { - operationType: 'create', - }); + // Query with operation type filter + const createHistory = await manager.getHistory('object', 'test_object', { + operationType: 'create', + }); - expect(createHistory.records.every(r => r.operationType === 'create')).toBe(true); - } + expect(createHistory.records.every(r => r.operationType === 'create')).toBe(true); }); it('should skip history record when checksum is unchanged', async () => { @@ -194,23 +184,19 @@ describe('Metadata History', () => { // Re-register with exact same content await manager.register('object', 'test_object', objectDef); - if (manager.getHistory) { - const history = await manager.getHistory('object', 'test_object'); + const history = await manager.getHistory('object', 'test_object'); - // Should only have one history record (the create) - // The second register should be skipped due to identical checksum - expect(history.records.length).toBe(1); - } + // Should only have one history record (the create) + // The second register should be skipped due to identical checksum + expect(history.records.length).toBe(1); }); it('should return empty history for non-existent metadata', async () => { - if (manager.getHistory) { - const history = await manager.getHistory('object', 'nonexistent'); + const history = await manager.getHistory('object', 'nonexistent'); - expect(history.records).toEqual([]); - expect(history.total).toBe(0); - expect(history.hasMore).toBe(false); - } + expect(history.records).toEqual([]); + expect(history.total).toBe(0); + expect(history.hasMore).toBe(false); }); it('should throw error when rolling back to non-existent version', async () => { @@ -219,10 +205,8 @@ describe('Metadata History', () => { label: 'Test', }); - if (manager.rollback) { - await expect( - manager.rollback('object', 'test_object', 999) - ).rejects.toThrow(); - } + await expect( + manager.rollback('object', 'test_object', 999) + ).rejects.toThrow(); }); });