You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[finding] check-clause2-carriers C4 is silent on every 2026-09-09 contract-review verdict — its VERDICT: discriminator and session-only Reviewed-by: grammar match neither the bold Verdict: heading dialect nor the isolated-subagent authorship the seats now write #17346
Filed by the os-dev dispatched on #17302 (branch claude/issue-17302-review-of-record, mode:subagent, skills seat session session_01MoTv7pn338AZ71owsp19gQ), as an out-of-scope finding met while measuring the review-of-record shape. ⛔ Not a triage grading; unlabeled by the filer.
The defect, with the probe
scripts/pm/check-clause2-carriers.mjs row C4 (the independence carrier, maintainer ruling 「同意 A」) discriminates "a contract-review verdict comment" with VERDICT_MARKER: a line whose first key is the uppercase word VERDICT followed by a colon (bullet, bold and backtick decoration tolerated). Its docblock says the marker was chosen from the live corpus on 2026-09-01, when verdicts opened a fenced block with VERDICT: PASS and REVIEWED-HEAD:.
The corpus moved. Every contract-review verdict measured on the 2026-09-09 board is written as an H51-shaped comment — a ## Contract review … heading, the head sha as a code span, **Verdict: PASS WITH FINDINGS** in bold mixed case, and the authorship pair as - **Implemented-by:** … / - **Reviewed-by:** … — and none of them carries an uppercase VERDICT: line. Probe, reproducible offline from the REST comment rows:
Consequence: cardVerdictAuthorship(...) reads none on those threads, so C4 never fires and --pair exit 0 says nothing about independence for any pair reviewed in the current dialect. The self-review shape C4 exists to refuse has no live population.
A second, independent gap behind the first: on those comments the Reviewed-by: value is prose — "isolated claude-fable-5-1 subagent, transcript-verified …" — with no session_… token, because an isolated review subagent has no session of its own. C4's grammar admits a SESSION ONLY on Reviewed-by: (its docblock, reading a of the 2026-09-02 ruling), so even with a discriminator that matched, the pair would read malformed on every one of them. references/contract-review.md :35–:36 give the implementer a branch grammar for exactly this reason and give the reviewer none.
#17302's C6 row reads only that a Reviewed-by: KEY LINE exists on the record (via C4's own key regex), deliberately not its value, so it is not blocked by this — but it also cannot stand in for C4. Two candidate remedies, not chosen here: (1) let C4 recognise a verdict by H51's heading marker beside the fenced VERDICT: form, and give Reviewed-by: a value grammar for an isolated subagent (e.g. the adopting seat's session, which the adoption records already write); (2) require the seats to write the fenced VERDICT: line and a session token, and let the reference say so. Either way the C4 fixtures (the 2026-09-01 shape) need the 2026-09-09 shape beside them.
Provenance: comment rows read via repo-scoped REST on 2026-09-10; regex readings reproduced with the file's own exported readVerdictAuthorship. Dedup: one targeted MCP search_issues (the REST search endpoint is refused in this container) — nearest neighbours #16303 (declaration near-misses, not verdict markers) and #13417 (PASS leaves no trace on the PR); neither names the discriminator.
Filed by the os-dev dispatched on #17302 (branch
claude/issue-17302-review-of-record,mode:subagent, skills seat sessionsession_01MoTv7pn338AZ71owsp19gQ), as an out-of-scope finding met while measuring the review-of-record shape. ⛔ Not a triage grading; unlabeled by the filer.The defect, with the probe
scripts/pm/check-clause2-carriers.mjsrow C4 (the independence carrier, maintainer ruling 「同意 A」) discriminates "a contract-review verdict comment" withVERDICT_MARKER: a line whose first key is the uppercase word VERDICT followed by a colon (bullet, bold and backtick decoration tolerated). Its docblock says the marker was chosen from the live corpus on 2026-09-01, when verdicts opened a fenced block withVERDICT: PASSandREVIEWED-HEAD:.The corpus moved. Every contract-review verdict measured on the 2026-09-09 board is written as an H51-shaped comment — a
## Contract review …heading, the head sha as a code span,**Verdict: PASS WITH FINDINGS**in bold mixed case, and the authorship pair as- **Implemented-by:** …/- **Reviewed-by:** …— and none of them carries an uppercaseVERDICT:line. Probe, reproducible offline from the REST comment rows:readVerdictAuthorship(body) === nullfor all four of: PR fix(types,metadata,cli): read the dialect text out ofcausefor operator-facing records #17073 comments 5597841101 and 5600239551, PR fix(plugin-security): stop letting org-admin row count decide whether a platform admin already exists #17116 comment 5600627944, PR feat(spec): ADR-0112 error envelope gains a producer-siderefusaldeclaration so a deliberate 5xx refusal keeps its caller-authored message (#16335) #17090 comment 5598904803 (all## Contract reviewcomments by H51'sCONTRACT_REVIEW_HEADING_MARKER, all carrying both authorship key lines).cardVerdictAuthorship(...)readsnoneon those threads, so C4 never fires and--pairexit 0 says nothing about independence for any pair reviewed in the current dialect. The self-review shape C4 exists to refuse has no live population.Reviewed-by:value is prose — "isolatedclaude-fable-5-1subagent, transcript-verified …" — with nosession_…token, because an isolated review subagent has no session of its own. C4's grammar admits a SESSION ONLY onReviewed-by:(its docblock, reading a of the 2026-09-02 ruling), so even with a discriminator that matched, the pair would readmalformedon every one of them.references/contract-review.md:35–:36 give the implementer a branch grammar for exactly this reason and give the reviewer none.What #17302 does and does not do about it
#17302's C6 row reads only that a
Reviewed-by:KEY LINE exists on the record (via C4's own key regex), deliberately not its value, so it is not blocked by this — but it also cannot stand in for C4. Two candidate remedies, not chosen here: (1) let C4 recognise a verdict by H51's heading marker beside the fencedVERDICT:form, and giveReviewed-by:a value grammar for an isolated subagent (e.g. the adopting seat's session, which the adoption records already write); (2) require the seats to write the fencedVERDICT:line and a session token, and let the reference say so. Either way the C4 fixtures (the 2026-09-01 shape) need the 2026-09-09 shape beside them.Provenance: comment rows read via repo-scoped REST on 2026-09-10; regex readings reproduced with the file's own exported
readVerdictAuthorship. Dedup: one targeted MCPsearch_issues(the REST search endpoint is refused in this container) — nearest neighbours #16303 (declaration near-misses, not verdict markers) and #13417 (PASS leaves no trace on the PR); neither names the discriminator.Generated by Claude Code