Skip to content

[finding] Dispatch-brief gap: an ADR-only / releases-nothing companion PR should carry the skip-changeset label from birth — Check Changeset red is otherwise guaranteed #12876

Description

@os-sales

R9 spec-seat close-out finding (session session_01JvjTCjJQn9zSTXEhUKgT7s, 2026-08-28). Recording only — unassigned. Destination when graded: one sentence in the pm-dispatch dispatch-brief template (the PR-form checklist a dev receives), plus optionally a platform-readings row.

What happened (PR #12839, 2026-08-28)

An ADR-only companion PR (single file under docs/adr/**, releases nothing) was opened without a changeset and without the skip-changeset label. Check Changeset went red by design, with its own log prescribing route 2: "If it releases nothing (including any 'skills/**' change — see #5947), apply the 'skip-changeset' label" — and explicitly rejecting the empty-changeset third option (#5471, because an all-empty changeset set stalls the release silently and greenly, #4898). Recovery was cheap but pure waste: a seat-side label edit + rerun_failed_jobs (the check reads labels at runtime, so a re-run suffices — no push needed; also a platform fact worth keeping).

The same gap recurred in kind on PR #12854 (comments-only diff measured as releasing nothing): the dev correctly wrote no changeset and flagged the label as the seat's to apply — one avoidable red-or-handoff per releases-nothing PR.

The fix shape (for whoever grades this)

Dispatch briefs for any PR expected to release nothing (ADR-only, .claude/**-only, comments-only where measured) should say: "this PR takes the skip-changeset LABEL, not a changeset file and not an empty one; the label is applied by the seat at PR-open time — say in the PR body that the diff releases nothing and why." The seat-side rule: apply the label proactively when the declared file surface is releases-nothing, before Check Changeset's first run.

Refs: #5947, #5471, #4898; PR #12839 (red → label → re-run green), PR #12854 (label applied pre-emptively, stayed green).

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions