Skip to content

Commit f75a38a

Browse files
os-zhuangclaude
andauthored
fix(spec): correct the repository name in the changesets config and the spec README badge (#12488) (#12825)
Two places still named `objectstack-ai/spec`, which is not the repository this monorepo lives in: - `.changeset/config.json` -> `changelog[1].repo` - `packages/spec/README.md` -> the "Try Online" StackBlitz badge target `README.md` is in `@objectstack/spec`'s published `files`, so the badge ships to npm readers. The `repo` option currently has no reader: `@changesets/cli/changelog` re-exports `@changesets/changelog-git`, which never reads the options object that `@changesets/apply-release-plan` passes as `config.changelog[1]`. It acquires one the moment anyone swaps in `@changesets/changelog-github`. Claude-Session: https://claude.ai/code/session_01PfaSTikked61BkcsB5Rn69 Co-authored-by: Claude <noreply@anthropic.com>
1 parent aacc248 commit f75a38a

3 files changed

Lines changed: 34 additions & 2 deletions

File tree

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
---
2+
"@objectstack/spec": patch
3+
---
4+
5+
fix(spec,repo): address the changesets `repo` option and the spec README's StackBlitz badge to `objectstack-ai/objectstack` (#12488)
6+
7+
Two places still name `objectstack-ai/spec`, which is not the repository this
8+
monorepo lives in:
9+
10+
- `.changeset/config.json``changelog[1].repo`
11+
- `packages/spec/README.md` — the "Try Online" StackBlitz badge target
12+
13+
The README badge is the user-visible half. `README.md` is listed in this
14+
package's `files`, so it ships in the npm tarball and every reader of
15+
`@objectstack/spec` on npm gets a "Try Online" button addressed to a repository
16+
that is not this one. The path the badge names —
17+
`examples/app-todo/objectstack.config.ts` — exists here, so correcting the
18+
owner/repo segment is the whole fix.
19+
20+
The `.changeset/config.json` half is hygiene with a measured expiry date rather
21+
than a bug that is firing. The configured generator `@changesets/cli/changelog`
22+
re-exports `@changesets/changelog-git`, whose `getReleaseLine(changeset)` and
23+
`getDependencyReleaseLine(changesets, dependenciesUpdated)` do not read the
24+
third argument — the options object that `@changesets/apply-release-plan`
25+
passes as `config.changelog[1]`. So `repo` has **no reader today**, and the
26+
wrong value has never produced a wrong link in any CHANGELOG this repo has
27+
generated. It acquires a reader the moment anyone swaps in
28+
`@changesets/changelog-github` — which is the usual reason to touch that block
29+
— and from then on every generated release line would link into the wrong
30+
repository, with nothing in the diff looking wrong.
31+
32+
No runtime behaviour changes.

.changeset/config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"changelog": [
44
"@changesets/cli/changelog",
55
{
6-
"repo": "objectstack-ai/spec"
6+
"repo": "objectstack-ai/objectstack"
77
}
88
],
99
"commit": false,

packages/spec/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# @objectstack/spec
22

3-
[![Try Online](https://developer.stackblitz.com/img/open_in_stackblitz.svg)](https://stackblitz.com/github/objectstack-ai/spec/tree/main/examples/app-todo?file=objectstack.config.ts)
3+
[![Try Online](https://developer.stackblitz.com/img/open_in_stackblitz.svg)](https://stackblitz.com/github/objectstack-ai/objectstack/tree/main/examples/app-todo?file=objectstack.config.ts)
44

55
The **Source of Truth** for the ObjectStack Protocol. Contains strictly typed Zod schemas that define every aspect of the system.
66

0 commit comments

Comments
 (0)