Commit e134fb6
committed
test(cli): drop the cardinality from allSixManifests() and its two stale comments
`allSixManifests()` was named for a population of six (5 CLI emissions + the
on-ramp). #16483 retired `os create example`, taking the CLI side to four, so
the helper now harvests five — measured by running it, not by reading it:
length=5 ids=["os init -t app","os init -t plugin","os init -t empty",
"os create plugin","npx create-objectstack"]
Nothing went red, because the harvest is derived from the live maps
(`Object.entries(TEMPLATES)` + `Object.entries(templates)`) and no assertion
counts to six. The number lived only in the identifier and in two comments,
which had gone stale in two different senses: the identifier overstated the
TOTAL, and the docblock above it overstated the CLI SUB-count ("the five the
two CLI commands render" — it is four).
The repair is to stop naming a moving fact, not to gate it: a detector for
"identifier's number disagrees with a runtime set" needs either NL parsing or
a hand-maintained map that drifts, which costs more than the p3 it catches.
- `allSixManifests` -> `allScaffolderManifests` (4 sites, all in this file)
- the docblock above it, and the header comment about the control, lose their
cardinality words rather than trading them for a smaller number
⛔ No count assertion added — that would convert a harmless statement into a
gate needing a hand update on every scaffold change. The derivation path and
the on-ramp firing control are untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015QE8qk46e5CHJxyQEUjbf81 parent 97adce2 commit e134fb6
1 file changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
356 | 356 | | |
357 | 357 | | |
358 | 358 | | |
359 | | - | |
360 | | - | |
| 359 | + | |
| 360 | + | |
361 | 361 | | |
362 | 362 | | |
363 | 363 | | |
| |||
376 | 376 | | |
377 | 377 | | |
378 | 378 | | |
379 | | - | |
| 379 | + | |
380 | 380 | | |
381 | 381 | | |
382 | 382 | | |
| |||
403 | 403 | | |
404 | 404 | | |
405 | 405 | | |
406 | | - | |
| 406 | + | |
407 | 407 | | |
408 | 408 | | |
409 | 409 | | |
| |||
414 | 414 | | |
415 | 415 | | |
416 | 416 | | |
417 | | - | |
| 417 | + | |
418 | 418 | | |
419 | 419 | | |
420 | 420 | | |
| |||
0 commit comments