|
| 1 | +// Copyright (c) 2026 ObjectStack. Licensed under the Apache-2.0 license. |
| 2 | + |
| 3 | +/** |
| 4 | + * PIN (#15892) — the project `os create plugin <name>` emits must PARSE, for |
| 5 | + * every name the command accepts. |
| 6 | + * |
| 7 | + * ## The defect |
| 8 | + * |
| 9 | + * `validateProjectName` accepts exactly what npm accepts, on purpose: `.`, `_` |
| 10 | + * and a leading digit are all legal in an npm package name, and |
| 11 | + * `@objectstack/plugin-foo.bar` is publishable. The emitted identifier used to |
| 12 | + * be the same string, copied: |
| 13 | + * |
| 14 | + * os create plugin foo.bar -> export const foo.barPlugin: Plugin = { |
| 15 | + * |
| 16 | + * exit 0, on a file that is not TypeScript — `foo.bar` in a binding position |
| 17 | + * is a property access. The maintainer's ruling (#15892, decision batch #64) |
| 18 | + * is that acceptance stays as npm's and the IDENTIFIER is derived, the way |
| 19 | + * `sanitizeNamespace()` already derives a namespace. |
| 20 | + * |
| 21 | + * ## Why the instrument is TypeScript's own parser |
| 22 | + * |
| 23 | + * "Does it look like an identifier" is the judgement that produced the defect |
| 24 | + * in the first place. `ts.createSourceFile` + `getSyntacticDiagnostics` asks |
| 25 | + * the compiler instead, and asks it about the bytes the template actually |
| 26 | + * emits rather than about a restatement of them. |
| 27 | + * |
| 28 | + * ⭐ The reading is only worth something because it CAN fail. Two controls: |
| 29 | + * |
| 30 | + * - `my-app` — an ordinary name, which must still yield exactly |
| 31 | + * `myAppPlugin`. A sanitiser that changes today's correct output is a |
| 32 | + * regression, not a fix, and a green parse would not notice. |
| 33 | + * - THE CANARY — the pre-fix bytes (the raw name interpolated back into the |
| 34 | + * identifier position) must produce at least one syntactic diagnostic. A |
| 35 | + * harness that resolves nothing, or is handed the wrong text, reports zero |
| 36 | + * diagnostics and reads exactly like a pass. |
| 37 | + * |
| 38 | + * ⚠️ `a_b` is in the ruling's list but does NOT discriminate on parseability: |
| 39 | + * `a_bPlugin` was always legal TypeScript. It is asserted on the MAPPING |
| 40 | + * instead (`a_b` -> `aB`), which is the half of the ruling it can fail. |
| 41 | + * |
| 42 | + * ## What this pin deliberately does not touch |
| 43 | + * |
| 44 | + * The emitted package name, its scope and the emitted directory name are the |
| 45 | + * user's string byte-for-byte (#15530 / #15816) — asserted below, so a future |
| 46 | + * edit that "fixes" the name instead of the identifier reddens here. |
| 47 | + */ |
| 48 | + |
| 49 | +import { describe, expect, it } from 'vitest'; |
| 50 | +import ts from 'typescript'; |
| 51 | +import { |
| 52 | + DEFAULT_PLACEMENT, |
| 53 | + sanitizeIdentifier, |
| 54 | + templates, |
| 55 | + type ScaffoldPlacement, |
| 56 | +} from '../src/commands/create.js'; |
| 57 | +import { validateProjectName } from '../src/commands/init.js'; |
| 58 | + |
| 59 | +/** |
| 60 | + * Syntactic (parse) diagnostics only — no lib, no resolution, no type layer. |
| 61 | + * `noLib`/`noResolve` keep the verdict about the grammar of these bytes, which |
| 62 | + * is the property the defect broke. |
| 63 | + */ |
| 64 | +function syntacticDiagnostics(fileName: string, source: string): readonly ts.Diagnostic[] { |
| 65 | + const sourceFile = ts.createSourceFile( |
| 66 | + fileName, |
| 67 | + source, |
| 68 | + ts.ScriptTarget.Latest, |
| 69 | + true, |
| 70 | + ts.ScriptKind.TS, |
| 71 | + ); |
| 72 | + const host: ts.CompilerHost = { |
| 73 | + getSourceFile: (requested) => (requested === fileName ? sourceFile : undefined), |
| 74 | + getDefaultLibFileName: () => 'lib.d.ts', |
| 75 | + writeFile: () => {}, |
| 76 | + getCurrentDirectory: () => '/', |
| 77 | + getCanonicalFileName: (f) => f, |
| 78 | + useCaseSensitiveFileNames: () => true, |
| 79 | + getNewLine: () => '\n', |
| 80 | + fileExists: (f) => f === fileName, |
| 81 | + readFile: (f) => (f === fileName ? source : undefined), |
| 82 | + }; |
| 83 | + const program = ts.createProgram( |
| 84 | + [fileName], |
| 85 | + { noLib: true, noResolve: true, target: ts.ScriptTarget.Latest }, |
| 86 | + host, |
| 87 | + ); |
| 88 | + return program.getSyntacticDiagnostics(sourceFile); |
| 89 | +} |
| 90 | + |
| 91 | +/** Render one file of the `plugin` template for a name and placement. */ |
| 92 | +function emit(file: string, name: string, placement: ScaffoldPlacement): string { |
| 93 | + const render = templates.plugin.filesFor(placement)[file]; |
| 94 | + if (!render) throw new Error(`the plugin template emits no ${file}`); |
| 95 | + const content = render(name); |
| 96 | + return typeof content === 'string' ? content : `${JSON.stringify(content, null, 2)}\n`; |
| 97 | +} |
| 98 | + |
| 99 | +/** The fenced `typescript` block of the emitted README — emission sites 3 and 4. */ |
| 100 | +function readmeTypescriptFence(readme: string): string { |
| 101 | + const fence = readme.match(/^```typescript\n([\s\S]*?)^```/m); |
| 102 | + if (!fence) throw new Error('the emitted README has no typescript fence'); |
| 103 | + return fence[1]; |
| 104 | +} |
| 105 | + |
| 106 | +function occurrences(haystack: string, needle: string): number { |
| 107 | + return haystack.split(needle).length - 1; |
| 108 | +} |
| 109 | + |
| 110 | +/** |
| 111 | + * The ruling's cases, plus the mapping each one is really about. `my-app` is |
| 112 | + * the control in BOTH directions — it must still produce `myAppPlugin`. |
| 113 | + */ |
| 114 | +const CASES: ReadonlyArray<{ name: string; identifier: string; why: string }> = [ |
| 115 | + { name: 'foo.bar', identifier: 'fooBar', why: 'a dot is legal for npm, illegal in an identifier' }, |
| 116 | + { name: '1foo', identifier: 'a1foo', why: 'a leading digit takes the fixed prefix' }, |
| 117 | + { name: 'a_b', identifier: 'aB', why: 'an underscore folds the way a hyphen already did' }, |
| 118 | + { name: 'my-app', identifier: 'myApp', why: 'CONTROL — today’s correct output must not move' }, |
| 119 | +]; |
| 120 | + |
| 121 | +const PLACEMENTS: readonly ScaffoldPlacement[] = ['standalone', 'in-repo']; |
| 122 | + |
| 123 | +describe('`os create plugin <name>` emits a parseable identifier', () => { |
| 124 | + it('accepts every case below — npm acceptance is unchanged by this fix', () => { |
| 125 | + for (const { name } of CASES) { |
| 126 | + expect(validateProjectName(name), name).toBeNull(); |
| 127 | + } |
| 128 | + }); |
| 129 | + |
| 130 | + it.each(CASES)('$name -> $identifier ($why)', ({ name, identifier }) => { |
| 131 | + expect(sanitizeIdentifier(name)).toBe(identifier); |
| 132 | + }); |
| 133 | + |
| 134 | + it.each(CASES)('emitted src/index.ts parses for $name', ({ name, identifier }) => { |
| 135 | + for (const placement of PLACEMENTS) { |
| 136 | + const source = emit('src/index.ts', name, placement); |
| 137 | + const diagnostics = syntacticDiagnostics('index.ts', source); |
| 138 | + expect( |
| 139 | + diagnostics.map((d) => ts.flattenDiagnosticMessageText(d.messageText, ' ')), |
| 140 | + `${name} @ ${placement}`, |
| 141 | + ).toEqual([]); |
| 142 | + expect(source).toContain(`export const ${identifier}Plugin: Plugin = {`); |
| 143 | + expect(source).toContain(`export default ${identifier}Plugin;`); |
| 144 | + } |
| 145 | + }); |
| 146 | + |
| 147 | + it.each(CASES)('emitted README.md fence parses for $name', ({ name, identifier }) => { |
| 148 | + const readme = emit('README.md', name, DEFAULT_PLACEMENT); |
| 149 | + const diagnostics = syntacticDiagnostics('readme.ts', readmeTypescriptFence(readme)); |
| 150 | + expect( |
| 151 | + diagnostics.map((d) => ts.flattenDiagnosticMessageText(d.messageText, ' ')), |
| 152 | + name, |
| 153 | + ).toEqual([]); |
| 154 | + expect(readme).toContain(`import { ${identifier}Plugin } from '@objectstack/plugin-${name}';`); |
| 155 | + }); |
| 156 | + |
| 157 | + it.each(CASES)('names the derived identifier in the README prose for $name', ({ name, identifier }) => { |
| 158 | + const readme = emit('README.md', name, DEFAULT_PLACEMENT); |
| 159 | + const prose = readme.replace(/^```[\s\S]*?^```/gm, ''); |
| 160 | + expect(prose).toContain(`\`${identifier}Plugin\``); |
| 161 | + expect(prose).toContain(`\`${name}\``); |
| 162 | + }); |
| 163 | + |
| 164 | + /** |
| 165 | + * The ruling's four emission sites: `src/index.ts` x2, `README.md` x2 — plus |
| 166 | + * the one prose mention the ruling also asks for, which is why the README |
| 167 | + * count is three. A new site must be added here deliberately. |
| 168 | + */ |
| 169 | + it.each(CASES)('reaches every emission site for $name', ({ name, identifier }) => { |
| 170 | + const index = emit('src/index.ts', name, DEFAULT_PLACEMENT); |
| 171 | + const readme = emit('README.md', name, DEFAULT_PLACEMENT); |
| 172 | + expect(occurrences(index, `${identifier}Plugin`)).toBe(2); |
| 173 | + expect(occurrences(readme, `${identifier}Plugin`)).toBe(3); |
| 174 | + // The defect's own shape, at the two sites that carry a binding. ⛔ Not a |
| 175 | + // bare `${name}Plugin` substring test: `a1foo` legitimately CONTAINS |
| 176 | + // `1foo`, so that spelling fails on a correct emission. |
| 177 | + if (name !== identifier) { |
| 178 | + expect(index).not.toContain(`export const ${name}Plugin`); |
| 179 | + expect(readme).not.toContain(`import { ${name}Plugin }`); |
| 180 | + } |
| 181 | + }); |
| 182 | + |
| 183 | + it.each(CASES)('leaves the emitted package name and directory as typed for $name', ({ name }) => { |
| 184 | + const manifest = JSON.parse(emit('package.json', name, DEFAULT_PLACEMENT)) as { name: string }; |
| 185 | + expect(manifest.name).toBe(`@objectstack/plugin-${name}`); |
| 186 | + expect(templates.plugin.dirName(name)).toBe(`plugin-${name}`); |
| 187 | + }); |
| 188 | + |
| 189 | + /** |
| 190 | + * CANARY — the pre-fix bytes. Without this, a harness that parsed the wrong |
| 191 | + * text (or nothing at all) would report zero diagnostics for every case above |
| 192 | + * and read as a pass. |
| 193 | + */ |
| 194 | + it('the parser reports the pre-fix emission as broken', () => { |
| 195 | + const fixed = emit('src/index.ts', 'foo.bar', DEFAULT_PLACEMENT); |
| 196 | + const preFix = fixed.split(`${sanitizeIdentifier('foo.bar')}Plugin`).join('foo.barPlugin'); |
| 197 | + expect(preFix).toContain('export const foo.barPlugin: Plugin = {'); |
| 198 | + expect(syntacticDiagnostics('index.ts', preFix).length).toBeGreaterThan(0); |
| 199 | + }); |
| 200 | + |
| 201 | + /** |
| 202 | + * `~` is npm-legal but `validateProjectName` does not admit it, so it never |
| 203 | + * reaches an emission site. Recorded because the card asserted it does. |
| 204 | + */ |
| 205 | + it('a tilde is refused by the validator, not by the sanitiser', () => { |
| 206 | + expect(validateProjectName('foo~bar')).not.toBeNull(); |
| 207 | + expect(sanitizeIdentifier('foo~bar')).toBe('fooBar'); |
| 208 | + }); |
| 209 | +}); |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?v=4&size=40){kind=avatar}
0 commit comments