fix(objectql): single-quote the shadowed package id in the [Registry] Collision warning (#12790)

* fix(objectql): single-quote the shadowed package id in the [Registry] Collision warning (#12609)

The cold-boot-order [Registry] Collision warning in
packages/objectql/src/registry.ts double-quoted the shadowed package id,
against this package's own convention (174 single-quoted vs 37 double-quoted
interpolated identifiers in operator prose, measured over non-test .ts under
packages/objectql/src — this line was one of the 37). #12563 already settled
the same ADR-0005 shadowing fact with single quotes on the automation side.

No existing pin held this message's quote character, so one is added,
asserting both the corrected spelling present and the pre-fix spelling
absent.

* predict(ablation #12609): reverting registry.ts:3050-3051 to double quotes
around ${shadowed._packageId} will:

- make `packages/objectql/src/registry.ts` contain
  `is shipped by package "${shadowed._packageId}"` (double-quoted) instead of
  the single-quoted spelling, confirmed present via anchored grep for the
  double-quote form and absent via anchored grep for the single-quote form
  (both anchored on the literal `is shipped by package ` prefix, not a bare
  quote character)
- flip RED exactly the new pin
  `[#12609] quotes the shadowed package id with single quotes, matching this
  package's own convention` in registry-collision-order.test.ts, on both of
  its assertions (`toContain("package '${PKG}'")` fails,
  `not.toContain('package "${PKG}"')` fails)
- leave every OTHER test in that file GREEN, including the sibling
  'COMMON COLD-BOOT ORDER — artifact first, then the sys_metadata row: warns'
  test's `toContain('shadows the package value')` assertion, which is the
  named positive control: it asserts the same warning fires with the same
  prose around the quote, so it cannot distinguish the two spellings and
  must stay green under this mutation.

Restoring via `git checkout HEAD -- packages/objectql/src/registry.ts` (HEAD
already carries the real fix, committed as 87ecd48 before this predict
commit) is predicted to reproduce that commit's blob exactly
(git hash-object match) and clear the mutation marker from the file.

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: os-zhuang

.changeset/registry-collision-quote-style.md

@@ -0,0 +1,49 @@
+---
+"@objectstack/objectql": patch
+---
+
+fix(objectql): single-quote the shadowed package id in the `[Registry] Collision` warning (#12609)
+
+`patch`: a shipped operator-facing log message changes its punctuation, and
+nothing in this repo parses the message beyond substring (`toContain`) test
+assertions — no regex or char-level match on the quote character was found
+(searched non-test `.ts`/`.tsx`/`.js` across the repo, and `content/`/`docs/`,
+for the message text; the two other hits are prose references to the warning
+by name, not parsers of its text). No public export, type, or behavior
+changes.
+
+## What changed
+
+`SchemaRegistry.registerItem`'s cold-boot-order `[Registry] Collision`
+warning (`packages/objectql/src/registry.ts`) double-quoted the shadowed
+package id — `` `... is shipped by package "${shadowed._packageId}" ...` `` —
+against this package's own convention: measured over non-test `.ts` under
+`packages/objectql/src`, quoted identifiers in operator prose are
+single-quoted 174 times against 37 double-quoted, and this line was one of
+the 37. #12563 already settled the same ADR-0005 shadowing fact on the
+automation side (`service-automation`) with single quotes
+(`package 'crm'`), so an operator whose boot hits both packages' collision
+warnings previously read one story in two spellings; this line now matches.
+
+Byte-identical otherwise. Only the quote character around the interpolated
+package id moved.
+
+## Scope
+
+One message, one site
+(`packages/objectql/src/registry.ts`'s `is shipped by package` warning —
+the guard that fires in the common cold-boot order, package registers
+first). A sibling `[Registry] Collision` warning in the same file
+(`ships from package`, the late-registration-order guard) also
+double-quotes its package id and is the same defect class, but is a
+different message and a different site — out of scope here, filed
+separately rather than swept in.
+
+## Test
+
+No existing pin held this message's literal quote character (`toContain(PKG)`
+assertions in `registry-collision-order.test.ts` matched either spelling); one
+is added — asserting the corrected spelling present **and** the pre-fix
+spelling absent, so it is red in both directions, not just green on the fix.
+
+<!-- adr-0087: not-required (no-migration-prescription) Log-text punctuation only; no authorable key, schema, or stored shape changed, so there is nothing for a migration to rewrite. -->

packages/objectql/src/registry-collision-order.test.ts

@@ -99,6 +99,26 @@ describe('[#12027] SchemaRegistry collision warning is order-symmetric', () => {
     expect(lines[0]).toContain('shadows the package value');
   });
 
+  it('[#12609] quotes the shadowed package id with single quotes, matching this package\'s own convention', () => {
+    // Measured over non-test `.ts` under `packages/objectql/src`: interpolated
+    // identifiers in operator prose are single-quoted 174 times against 37
+    // double-quoted — this line WAS one of the 37. `toContain` is not enough
+    // on its own (a substring check can't see which quote character surrounds
+    // it), so both directions are asserted explicitly: the correct spelling is
+    // present, and the pre-fix spelling is not — the same "would notice a
+    // disagreement" shape #12563 used for the sibling phrase in
+    // `service-automation`.
+    registry.registerItem('flow', { name: 'nightly_sync', label: 'packaged' }, 'name', PKG);
+
+    const lines = collisionsDuring(() => {
+      registry.registerItem('flow', { name: 'nightly_sync', label: 'runtime' }, 'name');
+    });
+
+    expect(lines).toHaveLength(1);
+    expect(lines[0]).toContain(`package '${PKG}'`);
+    expect(lines[0]).not.toContain(`package "${PKG}"`);
+  });
+
   it('LATE-REGISTRATION ORDER — sys_metadata row first, then the package: still warns', () => {
     // Unchanged behaviour, pinned so the repair cannot trade one order for the
     // other. This order is a marketplace install / HMR reload, not a boot.

packages/objectql/src/registry.ts

@@ -3048,7 +3048,7 @@ export class SchemaRegistry {
       if (shadowed) {
         console.warn(
           `[Registry] Collision: ${type}/${baseName} is shipped by package ` +
-          `"${shadowed._packageId}" and a runtime-authored row with the same name has ` +
+          `'${shadowed._packageId}' and a runtime-authored row with the same name has ` +
           `just been registered from sys_metadata. The runtime row now shadows the ` +
           `package value (ADR-0005 overlay precedence): every read of ${type}/${baseName} ` +
           `serves the stored row, not the packaged definition. That is the sanctioned ` +