Skip to content

Commit b8a16be

Browse files
claude[bot]claude
andauthored
docs(ci): stop hard-coding hook self-test deps in a comment (#14538)
The step comment claimed a fixed dependency set (jq + git only) for the whole "Claude hook guard self-tests" step, but the step discovers its matrices by glob (`find .claude/hooks -type f -name '*.selftest.sh'`), so a new matrix can legitimately need more than the two original ones did -- and one already does (guard-governed-enqueue.selftest.sh needs `node` for real, to run its two predicates). The comment never noticed; nothing catches that this prose fell out of date, since check:step-collectors cannot see this block (already admitted a few lines up). Rewrite the dependency sentence to say what is true of the STEP itself (jq + git, both already relied on bare elsewhere in this repo) plus whatever each discovered matrix declares in its own header -- because discovery is by glob, a matrix needing more must say so there, not here. Drop the stale "~2 s measured" figure along with it. No other line moves: step name, run: script, find discovery, and the rest of the "Hermetic by construction" paragraph are untouched. Co-authored-by: Claude <noreply@anthropic.com>
1 parent 53d3689 commit b8a16be

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

.github/workflows/lint.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1343,9 +1343,12 @@ jobs:
13431343
# own git repo and linked worktree under $TMPDIR, and both were re-run
13441344
# from a primary checkout, a detached HEAD and a non-repo cwd with
13451345
# identical results, so neither this checkout's depth nor its branch is an
1346-
# input. Needs `jq` and `git` and nothing else — no pnpm, no node, no
1347-
# build, no network (`jq` is in the runner image and is already relied on
1348-
# bare by cut-rc.yml and release.yml). ~2 s measured.
1346+
# input. This step itself needs only `jq` and `git` (both in the runner
1347+
# image; `jq` is already relied on bare by cut-rc.yml and release.yml),
1348+
# plus whatever each discovered matrix declares in its own header —
1349+
# discovery above is by glob, so a matrix needing more (node, pnpm, a
1350+
# built tree, a generator) must say so there; this comment is not the
1351+
# place to enumerate it.
13491352
- name: Claude hook guard self-tests (worktree-first · stash ban)
13501353
run: |
13511354
# Tolerate-and-collect (#10814) — see the note above this step. Each

0 commit comments

Comments
 (0)