Commit aae8843
fix(cli): every
The catalog in `packages/cli/src/commands/explain.ts` is hand-maintained and
does not derive from the spec, so its examples drifted behind the schemas they
claim to demonstrate. The sweep landed for #14811 parses every entry's
`example` against its real schema and pinned each failure as an `it.fails`
xfail. This corrects the six entries that carried one, disposes of a seventh
that had no type to check against at all, and promotes every xfail to a plain
assertion — the ledger is now empty.
- object select `options` are objects (`{ label, value }`), not strings
- field the prose row that was the source of that error: `string[]` ->
`SelectOption[]`, and the example demonstrates the real shape
- view `ViewSchema` is the per-object CONTAINER; a single view's keys
live inside a `list` / `form` / `listViews` / `formViews` slot
- agent `tools` was removed in spec 17 (ADR-0064) with no key its value
moves to — teach `skills`, `model` as an object, and the
required `label` / `instructions`
- app nav items need `id` plus the discriminant's own target key
(`objectName` / `dashboardName`); `logo` / `defaultRoute` are
not AppSchema keys
- dashboard widgets bind a `dataset` and select `dimensions` / `values`
(ADR-0021); `'chart'` is not a widget type; there is no
dashboard-level `layout`
- action `objectName`, `confirmText`, and `target` for a flow action;
`"button"` is not in the type enum
- trigger ADR-0088 retired the kind and its `TriggerSchema` never existed
— the entry becomes an explicit redirect to `hook` and a
`record_change` flow, the shape `workflow` already uses
Claude-Session: https://claude.ai/code/session_015QE8qk46e5CHJxyQEUjbf8
Co-authored-by: Claude <noreply@anthropic.com>os explain catalog example parses against its own schema (#16924)1 parent 2aaed99 commit aae8843
3 files changed
Lines changed: 193 additions & 88 deletions
File tree
- .changeset
- packages/cli
- src/commands
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
0 commit comments