Commit 8d60dcd
fix(qa): declare @objectstack/spec in http-conformance, retiring the ledger ceiling it inflated (#12060)
`packages/qa/http-conformance` imports `@objectstack/spec/contracts` from
`src/conformance.integration.test.ts` without declaring `@objectstack/spec`.
Under pnpm's strict layout the specifier reached no `@objectstack/spec`
anywhere on its resolution walk, so tsc answered TS2307 -- and that diagnostic
was one of the 3 recorded in the package's TEST_DEBT entry.
The number was therefore a reading of the INSTALL LAYOUT, not of this
package's types. Measured on one tree at 3954fb7, same sources, same built
closure, only the placement of `@objectstack/spec` differing:
as installed (undeclared) 3
`@objectstack/spec` symlinked into the root
node_modules, nothing else touched 2
packages/spec/dist moved aside 125
Declaring the dependency makes the program well-defined; the gate's own
re-measure then reports `TEST_DEBT records 3, tsc now reports 2 (-1)`, so the
ceiling is lowered to 2 and the entry's note re-tallied onto what it now
measures. Both surviving diagnostics are in third-party `.d.ts` files
(@better-auth/core's `bun:sqlite`, @better-fetch/fetch's `Timer`); no
diagnostic is introduced here.
devDependencies rather than dependencies: the import is `import type`, in a
test file, and every other workspace package this package uses only from its
tests already sits there. `workspaceBuildGraph` reads devDependencies too, so
the declaration gets the same BUILT CLOSURE protection either way.
Claude-Session: https://claude.ai/code/session_019siH5jDmk5hrayvfyojUqR
Co-authored-by: Claude <noreply@anthropic.com>1 parent f7b25c5 commit 8d60dcd
3 files changed
Lines changed: 21 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1059 | 1059 | | |
1060 | 1060 | | |
1061 | 1061 | | |
1062 | | - | |
1063 | | - | |
1064 | | - | |
1065 | | - | |
1066 | | - | |
1067 | | - | |
| 1062 | + | |
| 1063 | + | |
| 1064 | + | |
| 1065 | + | |
| 1066 | + | |
| 1067 | + | |
| 1068 | + | |
| 1069 | + | |
| 1070 | + | |
| 1071 | + | |
| 1072 | + | |
| 1073 | + | |
| 1074 | + | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
| 1078 | + | |
1068 | 1079 | | |
1069 | 1080 | | |
1070 | 1081 | | |
| |||
0 commit comments