|
| 1 | +--- |
| 2 | +'@objectstack/lint': minor |
| 3 | +--- |
| 4 | + |
| 5 | +`widget-measures-missing` — the empty-measure selection is reported on every widget family, not just charts |
| 6 | + |
| 7 | +`chart-measures-missing` (#15462) reported the authoring placeholder only for the chart |
| 8 | +family, but the return that produces it is type-independent. At the `@object-ui` revision |
| 9 | +this repo pins (`.objectui-sha` = `a472b0716`), `packages/plugin-dashboard/src/DatasetWidget.tsx:683` |
| 10 | +reads `if (values.length === 0)` and returns *"Pick measures (values) for this dataset |
| 11 | +widget."* ABOVE `isMetric` (`:423`, over `METRIC_TYPES` at `:343`), `isTable` (`:424`) and |
| 12 | +the chart branch alike. So a `metric`, `kpi`, `gauge`, `solid-gauge`, `bullet`, `table` or |
| 13 | +`pivot` widget that selects no measures renders the same placeholder — the KPI number or |
| 14 | +the table the author declared is not drawn at all — and nothing reported it: |
| 15 | +`table-count-only` requires `values.length > 0` before it looks, and the rules that iterate |
| 16 | +`dimensions[]`/`values[]` are silent on an empty array by construction. |
| 17 | + |
| 18 | +- **New id `widget-measures-missing`** — a NON-chart declared widget type selects no |
| 19 | + measures. Warning tier, suppressible per widget with |
| 20 | + `suppressWarnings: ['widget-measures-missing']`, exactly as the chart-family id is. The |
| 21 | + message states the consequence its family actually has (the single KPI number is not |
| 22 | + drawn / no table is rendered) and the hint names the dataset's declared measures. |
| 23 | +- **`chart-measures-missing` is unchanged** — same id, same chart-family population, same |
| 24 | + message and same suppression. The condition split rather than widened because "chart" |
| 25 | + stops naming it once the population is every family, while the old id is reachable from |
| 26 | + the package barrel (a public-surface contract) and may already be written into a board's |
| 27 | + `suppressWarnings`. |
| 28 | +- `chart-dimensions-missing` stays chart-family only: a dimensionless `metric` or `table` |
| 29 | + is what those families are for. |
| 30 | + |
| 31 | +The two never double-report one widget, in the pin's own order: the measures check runs |
| 32 | +before the dimensions one, and `table-count-only` already skips an empty selection. |
0 commit comments