Commit 49f0dcf
feat(core): retire the inert PluginMetadata surfaces — configSchema with PluginConfigValidator, and hotReloadable (ADR-0049) (#12689)
* feat(core): retire PluginMetadata.configSchema and PluginConfigValidator under ADR-0049 (#11982)
The kernel-owned plugin-config-validation surface could never run: the
loader's one call site passed no config, plugin factories close over their
config so the kernel never receives it, and zero plugins declared a
configSchema (measured with positive controls; maintainer ruled Option B,
2026-08-27, decision-inbox batch 5).
- remove PluginMetadata.configSchema and the always-early-returning
validatePluginConfig path from PluginLoader
- delete PluginConfigValidator / createPluginConfigValidator and their unit
test; unpublish them from the security barrel
- record the retirement in ADR-0025 section 3.7: re-declaring a kernel-owned
config-validation surface is a fresh decision for the day the distribution
layer lands, with the zero-caller measurement as starting evidence
- drop the ADVANCED_FEATURES.md section whose example promised 'Config is
validated before init is called' — false on this ref
- pin the retirement: barrel no longer exports the validator (runtime), a
declared configSchema no longer type-checks (compile-time, via the
type-check DEBT ratchet), startupTimeout as the live-sibling positive
control
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LZbWd2jNV1FErXTPSS4Dry
* feat(core): retire PluginMetadata.hotReloadable under ADR-0049 (#12587)
Declared 'Whether plugin supports hot reload' and documented, with zero
reads and zero declarations: HotReloadManager.reloadPlugin gates only on its
own registered reload configs, so hotReloadable: false was hot-reloaded
identically to true — a reload-safety assurance the runtime never honoured
(maintainer ruled Option B, 2026-08-27, decision-inbox batch 5, same batch
as the configSchema retirement).
- remove PluginMetadata.hotReloadable and its ADVANCED_FEATURES.md line
- drop the field from ADR-0025's present-capability inventory (the section
3.7 record already names this sibling retirement; the ADR's
distribution-layer design prose keeps its forward-looking mentions)
- pin: a declared hotReloadable no longer type-checks (compile-time, via the
type-check DEBT ratchet)
- add the family changeset covering both retirements (@objectstack/core
minor under the lockstep launch-window convention, with the ADR-0087
runtime-interface-only disposition)
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LZbWd2jNV1FErXTPSS4Dry
* test(core,rest): host the retirement compile pins in a compiled program (#11982, #12587)
check:type-check-coverage correctly refused the first shape: @objectstack/core
has no typecheck script (type-check DEBT ledger entry), so a @ts-expect-error
in core is a phantom pin no tsc program a typecheck script runs would
evaluate, and PHANTOM_PIN_DEBT is closed to new entries.
- core keeps the RUNTIME pins (security barrel no longer publishes
PluginConfigValidator / createPluginConfigValidator, live-sibling positive
control on the namespace)
- the COMPILE-TIME pins move to packages/rest, whose tsconfig.test.json
program is run by its typecheck script (check:test-typecheck, EXACT
per-file ratchet) and resolves @objectstack/core to the BUILT dist .d.ts —
so the directives pin the published contract consumers actually see, in the
package that carries the retirement's worked replacement (#11637 seam
parse)
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LZbWd2jNV1FErXTPSS4Dry
* docs: align the hand-written plugin docs with the ADR-0049 retirements (#11982, #12587)
Docs-drift pass over the six pages the drift bot anchored to this diff:
- plugins/anatomy.mdx: the Plugin-class example carried the retired
configSchema field with a comment claiming the loader validates it; the
block now shows constructor-owned config and names the retirement
- plugins/index.mdx: the Configuration Validation bullet and the configSchema
half of the securePlugin example removed (signature kept - live surface);
replacement paragraph states the plugin-owned self-parse pattern
- protocol/kernel/index.mdx: the Configuration Management snippet and the
fail-fast callout no longer document the retired field as merely
'postponed' - both now state the retirement and the self-parse seam
No change, with the reason measured per page: automation/flows.mdx names the
ADR-0018 node-executor configSchema (different surface);
getting-started/quick-reference.mdx names spec's plugin-validator.zod.ts
PluginMetadata (locally-declared homonym, live);
protocol/kernel/plugin-spec.mdx teaches the surviving self-parse pattern -
its phantom manifest file-map row predates this diff and is filed as #12690.
content/docs/releases/v17.mdx is release-owned and untouched; its four
configSchema mentions are all the ADR-0018 / driver surfaces, none the
kernel field.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LZbWd2jNV1FErXTPSS4Dry
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 96732b0 commit 49f0dcf
12 files changed
Lines changed: 212 additions & 568 deletions
File tree
- .changeset
- content/docs
- plugins
- protocol/kernel
- docs/adr
- packages
- core
- src
- security
- rest/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
30 | 29 | | |
31 | 30 | | |
32 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
284 | 284 | | |
285 | 285 | | |
286 | 286 | | |
287 | | - | |
288 | 287 | | |
289 | 288 | | |
290 | 289 | | |
291 | | - | |
292 | | - | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
293 | 295 | | |
| 296 | + | |
294 | 297 | | |
295 | 298 | | |
296 | 299 | | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | 300 | | |
302 | | - | |
| 301 | + | |
303 | 302 | | |
304 | 303 | | |
305 | 304 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
403 | 403 | | |
404 | 404 | | |
405 | 405 | | |
406 | | - | |
407 | | - | |
408 | | - | |
409 | | - | |
410 | | - | |
411 | | - | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
412 | 411 | | |
413 | 412 | | |
414 | 413 | | |
415 | | - | |
416 | | - | |
417 | | - | |
418 | | - | |
419 | | - | |
420 | 414 | | |
421 | 415 | | |
422 | 416 | | |
| |||
487 | 481 | | |
488 | 482 | | |
489 | 483 | | |
490 | | - | |
491 | | - | |
492 | | - | |
493 | | - | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
494 | 489 | | |
495 | 490 | | |
496 | 491 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
| 60 | + | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
152 | | - | |
| 152 | + | |
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
| |||
276 | 276 | | |
277 | 277 | | |
278 | 278 | | |
279 | | - | |
280 | | - | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
281 | 291 | | |
282 | 292 | | |
283 | 293 | | |
| |||
496 | 506 | | |
497 | 507 | | |
498 | 508 | | |
499 | | - | |
500 | 509 | | |
501 | 510 | | |
502 | 511 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
285 | 285 | | |
286 | 286 | | |
287 | 287 | | |
288 | | - | |
289 | | - | |
290 | | - | |
291 | | - | |
292 | | - | |
293 | | - | |
294 | | - | |
295 | | - | |
296 | | - | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | | - | |
302 | | - | |
303 | | - | |
304 | | - | |
305 | | - | |
306 | | - | |
307 | | - | |
308 | | - | |
309 | | - | |
310 | | - | |
311 | | - | |
312 | 288 | | |
313 | 289 | | |
314 | 290 | | |
| |||
367 | 343 | | |
368 | 344 | | |
369 | 345 | | |
370 | | - | |
371 | 346 | | |
372 | 347 | | |
373 | 348 | | |
374 | | - | |
375 | 349 | | |
376 | 350 | | |
377 | 351 | | |
| |||
Lines changed: 36 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
7 | 5 | | |
8 | 6 | | |
9 | 7 | | |
| |||
41 | 39 | | |
42 | 40 | | |
43 | 41 | | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
48 | 51 | | |
49 | 52 | | |
50 | 53 | | |
| |||
53 | 56 | | |
54 | 57 | | |
55 | 58 | | |
56 | | - | |
57 | | - | |
58 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
59 | 65 | | |
60 | 66 | | |
61 | 67 | | |
| |||
106 | 112 | | |
107 | 113 | | |
108 | 114 | | |
109 | | - | |
110 | 115 | | |
111 | 116 | | |
112 | 117 | | |
| |||
115 | 120 | | |
116 | 121 | | |
117 | 122 | | |
118 | | - | |
119 | 123 | | |
120 | 124 | | |
121 | 125 | | |
| |||
153 | 157 | | |
154 | 158 | | |
155 | 159 | | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | 160 | | |
162 | 161 | | |
163 | 162 | | |
| |||
403 | 402 | | |
404 | 403 | | |
405 | 404 | | |
406 | | - | |
407 | | - | |
408 | | - | |
409 | | - | |
410 | | - | |
411 | | - | |
412 | | - | |
413 | | - | |
414 | | - | |
415 | | - | |
416 | | - | |
417 | | - | |
418 | | - | |
419 | | - | |
420 | | - | |
421 | | - | |
422 | 405 | | |
423 | 406 | | |
424 | 407 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
| |||
35 | 34 | | |
36 | 35 | | |
37 | 36 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
0 commit comments