Skip to content

Commit 4281c5d

Browse files
committed
test(lint): drop the stack.datasets residual rows the sweep has outlived
Same self-expiry, one layer down from the gate. `RESIDUAL_THROWS` recorded that `validateReferenceIntegrity` still threw on a non-record `stack.datasets` member through `indexDatasets`; #15741 re-pointed that reader, so the sweep went red demanding a throw that no longer happens. The rows come out because the assertion failed, which is what "exact in both directions" is for — a residual list that only ever grew would rot into a list of excuses. `objects[].fields` / `validateStackExpressions` (#15742) stays: measured, still throwing on this tree. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012zGPuVVX3deAx9LdjK8jCk
1 parent fc2f3b8 commit 4281c5d

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

packages/lint/src/non-record-object-entry.test.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -342,15 +342,17 @@ const SWEPT_COLLECTIONS: readonly SweptCollection[] = [
342342
*
343343
* Every entry names a reader OUTSIDE what #15636 could touch:
344344
*
345-
* - `stack.datasets` — `indexDatasets` in `validate-chart-bindings.ts`, which
346-
* was another change's file when this landed. Re-pointed by #15575.
347345
* - `objects[].fields` — `buildFieldIndex` in `validate-expressions.ts:137`,
348346
* which casts inline instead of through a helper, so the `asArray` sweeps
349347
* that produced #15552 and #15636 never saw it. Filed as #15742.
348+
*
349+
* `stack.datasets` was here too, for `indexDatasets` in
350+
* `validate-chart-bindings.ts`. #15741 re-pointed that reader and these
351+
* assertions went red demanding a throw that no longer happens, which is the
352+
* both-directions half earning its keep: the rows came out because the sweep
353+
* failed, not because anyone went looking for them.
350354
*/
351355
const RESIDUAL_THROWS: Readonly<Record<string, readonly string[]>> = {
352-
'stack.datasets · null': ['validateReferenceIntegrity'],
353-
'stack.datasets · undefined': ['validateReferenceIntegrity'],
354356
'objects[].fields · null': ['validateStackExpressions'],
355357
'objects[].fields · undefined': ['validateStackExpressions'],
356358
};

0 commit comments

Comments
 (0)