Commit 1c032a2
committed
docs(cli): record the blast-radius reason for the guard, not a false one
Contract review drove `dependsOn` rather than reading the report, and the
recorded reason was partly false. The choice is unchanged; only the reason is.
Two corrections, both comment-only:
* `dependsOn` CAN be brought inside this command's envelope — a `catch()`
override on the parse answers exit 1 with `{error}` on the `--json` face
and an empty stderr. "The framework spelling cannot be enveloped" was the
sentence the guard leaned on, and it is not true. The real objection is
scope: that override re-shapes EVERY parse error on this command — every
unknown flag and bad value moving from exit 2/stderr to exit 1/stdout,
carrying oclif's prose and its `--help` hint inside the JSON `error`
string — where the guard moves one invocation class and leaves the rest.
* The stack trace beside oclif's refusal is a DEV-ENTRY artefact of
`settings.debug` on `bin/run-dev.js`; the shipped `bin/run.js` prints the
pretty message with no stack. The old comment generalised the dev entry.
The test header carried the same false claim and said these pins "fail that
implementation" — a `catch()` override passes them. It now says so, and says
a green here is not a verdict on the choice. No assertion is touched: the
`expect(` count is 18 before and after, and the diff is comment lines only.
Behaviour, pins and changeset are unchanged.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D47qPfEWVPmhguWgBZCi5N1 parent 3c21254 commit 1c032a2
2 files changed
Lines changed: 31 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
541 | 541 | | |
542 | 542 | | |
543 | 543 | | |
544 | | - | |
545 | | - | |
546 | | - | |
547 | | - | |
548 | | - | |
549 | | - | |
550 | | - | |
551 | | - | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
552 | 567 | | |
553 | 568 | | |
554 | 569 | | |
| |||
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
43 | 47 | | |
44 | 48 | | |
45 | 49 | | |
| |||
0 commit comments