From eaf21068d1bbc25e782c0d35d2ffaf450a2aa467 Mon Sep 17 00:00:00 2001 From: nullStack65 Date: Thu, 19 Nov 2026 13:03:00 -0500 Subject: [PATCH 1/2] Run ARC CI when a PR is retargeted onto a release branch PR #100 was retargeted to release/native-0.1.10 after all its commits were pushed, so the pull_request trigger (default types, no edited) never ran ARC and the regression merged unchecked. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/closura-arc-ci.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/closura-arc-ci.yml b/.github/workflows/closura-arc-ci.yml index 8531b2d655c37..c7f5cfb4b0130 100644 --- a/.github/workflows/closura-arc-ci.yml +++ b/.github/workflows/closura-arc-ci.yml @@ -8,6 +8,11 @@ on: # exact commit; the private fleet rollout builds only commits that passed. branches: [feat/assemblyai-current, release/native-0.1.10] pull_request: + # `edited` covers retargeting a PR onto a release branch. Without it, a PR + # whose commits were all pushed before the retarget merged with no ARC run. + # Any edit reruns the full job rather than skipping it, so a skipped check + # can never stand in for a real result on the same head. + types: [opened, synchronize, reopened, edited, ready_for_review] branches: [feat/assemblyai-current, release/native-0.1.10] workflow_dispatch: From 4ae4568d7319399a6f8e5384f542d935dd4229cc Mon Sep 17 00:00:00 2001 From: Kameron Smith Date: Thu, 19 Nov 2026 14:42:58 -0500 Subject: [PATCH 2/2] Keep bot-triggered edit runs from cancelling the real ARC run Review round for this PR (Fable 5.2, non-blocking findings 1 and 2): an edit by a non-founder actor such as CodeRabbit started a run that cancelled the in-progress founder run and then skipped its only job. PR runs now also group by triggering actor. ready_for_review is dropped because the job has no draft condition, so it only added a rerun of the same head. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/closura-arc-ci.yml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/closura-arc-ci.yml b/.github/workflows/closura-arc-ci.yml index c7f5cfb4b0130..6ab8a3312e27c 100644 --- a/.github/workflows/closura-arc-ci.yml +++ b/.github/workflows/closura-arc-ci.yml @@ -10,9 +10,10 @@ on: pull_request: # `edited` covers retargeting a PR onto a release branch. Without it, a PR # whose commits were all pushed before the retarget merged with no ARC run. - # Any edit reruns the full job rather than skipping it, so a skipped check - # can never stand in for a real result on the same head. - types: [opened, synchronize, reopened, edited, ready_for_review] + # A founder's edit reruns the full job. An edit by anyone else (for example + # CodeRabbit rewriting the description) starts a run whose job is skipped; + # the concurrency group below keeps it from cancelling the real run. + types: [opened, synchronize, reopened, edited] branches: [feat/assemblyai-current, release/native-0.1.10] workflow_dispatch: @@ -21,8 +22,10 @@ permissions: concurrency: # Pushes group by exact commit, so a burst of merges never cancels a queued - # head: every merged head keeps its own check run. - group: t3-fork-arc-${{ github.workflow }}-${{ github.event_name == 'push' && github.sha || github.event.pull_request.number || github.ref }} + # head: every merged head keeps its own check run. PR runs also group by the + # triggering actor, so a bot's edit-triggered (skipped) run never cancels a + # founder's in-progress run. + group: t3-fork-arc-${{ github.workflow }}-${{ github.event_name == 'push' && github.sha || github.event.pull_request.number || github.ref }}-${{ github.event_name == 'pull_request' && github.triggering_actor || 'x' }} cancel-in-progress: ${{ github.event_name == 'pull_request' }} jobs: