From bc06adbe12cd03889cbf89dece2cd277bca5cc27 Mon Sep 17 00:00:00 2001 From: himura467 Date: Mon, 2 Nov 2026 16:02:56 +0900 Subject: [PATCH] refactor: rename Nack::Spec.no_entity_body? to no_content? --- lib/nack/spec.rb | 2 +- test/spec_spec.rb | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/nack/spec.rb b/lib/nack/spec.rb index e5acde4..e13c0eb 100644 --- a/lib/nack/spec.rb +++ b/lib/nack/spec.rb @@ -29,7 +29,7 @@ def valid_content_length?(value) value.is_a?(String) && value.ascii_only? && /\A[0-9]+\z/.match?(value) end - def no_entity_body?(status, request) + def no_content?(status, request) request.request_method.get_string == "HEAD" || ((100..199).cover?(status) && status != 101) || status == 204 || status == 205 || status == 304 end diff --git a/test/spec_spec.rb b/test/spec_spec.rb index 1818853..c21cbeb 100644 --- a/test/spec_spec.rb +++ b/test/spec_spec.rb @@ -52,18 +52,18 @@ Nack::Spec.valid_content_length?(:a).must_equal false end - it "knows which responses carry no entity body" do + it "knows which responses carry no content" do request = Struct.new(:request_method) get = request.new(IO::Buffer.for("GET")) head = request.new(IO::Buffer.for("HEAD")) - Nack::Spec.no_entity_body?(100, get).must_equal true - Nack::Spec.no_entity_body?(199, get).must_equal true - Nack::Spec.no_entity_body?(204, get).must_equal true - Nack::Spec.no_entity_body?(205, get).must_equal true - Nack::Spec.no_entity_body?(304, get).must_equal true - Nack::Spec.no_entity_body?(200, head).must_equal true - Nack::Spec.no_entity_body?(101, get).must_equal false - Nack::Spec.no_entity_body?(200, get).must_equal false + Nack::Spec.no_content?(100, get).must_equal true + Nack::Spec.no_content?(199, get).must_equal true + Nack::Spec.no_content?(204, get).must_equal true + Nack::Spec.no_content?(205, get).must_equal true + Nack::Spec.no_content?(304, get).must_equal true + Nack::Spec.no_content?(200, head).must_equal true + Nack::Spec.no_content?(101, get).must_equal false + Nack::Spec.no_content?(200, get).must_equal false end it "accepts interim statuses" do