squash! lint

Author: aduh95

lib/internal/webstreams/util.js

@@ -4,13 +4,12 @@ const {
   ArrayPrototypePush,
   ArrayPrototypeShift,
   AsyncIteratorPrototype,
+  FunctionPrototypeCall,
   MathMax,
   NumberIsNaN,
   PromisePrototypeThen,
   PromiseReject,
   PromiseResolve,
-  ReflectGet,
-  ReflectApply,
   Symbol,
 } = primordials;
 
@@ -147,9 +146,25 @@ function enqueueValueWithSize(controller, value, size) {
   controller[kState].queueTotalSize += size;
 }
 
-function createPromiseCallback(name, fn, thisArg) {
+// Arity-specialized variants of the promise-callback wrapper. The generic
+// rest-parameter + ReflectApply form allocated an arguments array on every
+// invocation; these run on per-chunk hot paths (pull/write/transform), so
+// each known call-site arity gets its own wrapper. The exact number of
+// arguments passed through to the user callback is observable and must be
+// preserved.
+function createPromiseCallbackNoParams(name, fn, thisArg) {
   validateFunction(fn, name);
-  return async (...args) => ReflectApply(fn, thisArg, args);
+  return async () => FunctionPrototypeCall(fn, thisArg);
+}
+
+function createPromiseCallback1Param(name, fn, thisArg) {
+  validateFunction(fn, name);
+  return async (arg) => FunctionPrototypeCall(fn, thisArg, arg);
+}
+
+function createPromiseCallback2Params(name, fn, thisArg) {
+  validateFunction(fn, name);
+  return async (arg1, arg2) => FunctionPrototypeCall(fn, thisArg, arg1, arg2);
 }
 
 function isPromisePending(promise) {
@@ -208,7 +223,9 @@ module.exports = {
   canCopyArrayBuffer,
   cloneAsUint8Array,
   copyArrayBuffer,
-  createPromiseCallback,
+  createPromiseCallbackNoParams,
+  createPromiseCallback1Param,
+  createPromiseCallback2Params,
   customInspect,
   defaultSizeAlgorithm,
   dequeueValue,

src/node_buffer.cc

@@ -1584,11 +1584,15 @@ void CopyArrayBuffer(const FunctionCallbackInfo<Value>& args) {
 
   CHECK_LE(destination_offset, static_cast<uint64_t>(destination_byte_length));
   CHECK_LE(source_offset, static_cast<uint64_t>(source_byte_length));
-  CHECK_LE(bytes_to_copy, static_cast<uint64_t>(destination_byte_length) - destination_offset);
-  CHECK_LE(bytes_to_copy, static_cast<uint64_t>(source_byte_length) - source_offset);
-
-  uint8_t* dest = static_cast<uint8_t*>(destination) + static_cast<size_t>(destination_offset);
-  uint8_t* src = static_cast<uint8_t*>(source) + static_cast<size_t>(source_offset);
+  CHECK_LE(bytes_to_copy,
+           static_cast<uint64_t>(destination_byte_length) - destination_offset);
+  CHECK_LE(bytes_to_copy,
+           static_cast<uint64_t>(source_byte_length) - source_offset);
+
+  uint8_t* dest = static_cast<uint8_t*>(destination) +
+                  static_cast<size_t>(destination_offset);
+  uint8_t* src =
+      static_cast<uint8_t*>(source) + static_cast<size_t>(source_offset);
   memcpy(dest, src, static_cast<size_t>(bytes_to_copy));
 }