lib: add internal/primordials-staging module

Signed-off-by: LiviaMedeiros <livia@cirno.name>

Author: LiviaMedeiros

lib/internal/freeze_intrinsics.js

@@ -128,13 +128,12 @@ const {
   globalThis,
   unescape,
 } = primordials;
-
 const {
   Intl,
   SharedArrayBuffer,
   Temporal,
   WebAssembly,
-} = globalThis;
+} = require('internal/primordials_staging');
 
 module.exports = function() {
   const { Console } = require('internal/console/constructor');

lib/internal/fs/utils.js

@@ -23,8 +23,8 @@ const {
   Symbol,
   TypedArrayPrototypeAt,
   TypedArrayPrototypeIncludes,
-  globalThis,
 } = primordials;
+const primordialsStaging = require('internal/primordials_staging');
 
 const { Buffer } = require('buffer');
 const {
@@ -441,15 +441,15 @@ function nsFromTimeSpecBigInt(sec, nsec) {
 let TemporalInstant;
 
 function instantFromNs(nsec) {
-  TemporalInstant ??= globalThis.Temporal?.Instant;
+  TemporalInstant ??= primordialsStaging.Temporal?.Instant;
   if (TemporalInstant === undefined) {
     throw new ERR_NO_TEMPORAL();
   }
   return new TemporalInstant(nsec);
 }
 
 function instantFromTimeSpecMs(msec, nsec) {
-  TemporalInstant ??= globalThis.Temporal?.Instant;
+  TemporalInstant ??= primordialsStaging.Temporal?.Instant;
   if (TemporalInstant === undefined) {
     throw new ERR_NO_TEMPORAL();
   }

lib/internal/modules/esm/translators.js

@@ -13,8 +13,8 @@ const {
   StringPrototypeReplaceAll,
   StringPrototypeSlice,
   StringPrototypeStartsWith,
-  globalThis,
 } = primordials;
+const primordialsStaging = require('internal/primordials_staging');
 
 const {
   compileFunctionForCJSLoader,
@@ -554,7 +554,7 @@ const wasmInstances = new SafeWeakMap();
 translators.set('wasm', function(url, translateContext) {
   const { source } = translateContext;
   // WebAssembly global is not available during snapshot building, so we need to get it lazily.
-  const { WebAssembly } = globalThis;
+  const { WebAssembly } = primordialsStaging;
   assertBufferSource(source, false, 'load');
 
   debug(`Translating WASMModule ${url}`, translateContext);

lib/internal/primordials_staging.js

@@ -0,0 +1,88 @@
+'use strict';
+
+// This file stores JS builting that can not become primordials yet because
+// they can be disabled by runtime flags, or are not enabled by default yet.
+
+// Without this module, the only choice we would have is getting them from
+// the global proxy which is mutable from userland. This is especially important
+// for lazy-loaded builting required in modules participating in early bootstrap.
+// In such modules, we are usually unable to get these builting synchronously,
+// this applies to synchronous destructuring of this module.
+// Importing the module itself is fine at any point, including top level of file.
+
+let _AsyncDisposableStack;
+let _DisposableStack;
+let _Float16Array;
+let _Intl;
+let _Iterator;
+let _ShadowRealm;
+let _SharedArrayBuffer;
+let _Temporal;
+let _Uint8ArrayFromHex;
+let _Uint8ArrayFromBase64;
+let _WebAssembly;
+
+module.exports = {
+  get AsyncDisposableStack() {
+    return _AsyncDisposableStack;
+  },
+  get DisposableStack() {
+    return _DisposableStack;
+  },
+  get Float16Array() {
+    return _Float16Array;
+  },
+  get Intl() {
+    return _Intl;
+  },
+  get Iterator() {
+    return _Iterator;
+  },
+  get ShadowRealm() {
+    return _ShadowRealm;
+  },
+  get SharedArrayBuffer() {
+    return _SharedArrayBuffer;
+  },
+  get Temporal() {
+    return _Temporal;
+  },
+  get Uint8ArrayFromHex() {
+    return _Uint8ArrayFromHex;
+  },
+  get Uint8ArrayFromBase64() {
+    return _Uint8ArrayFromBase64;
+  },
+  get WebAssembly() {
+    return _WebAssembly;
+  },
+  _init({
+    AsyncDisposableStack,
+    DisposableStack,
+    Float16Array,
+    Intl,
+    Iterator,
+    ShadowRealm,
+    SharedArrayBuffer,
+    Temporal,
+    Uint8Array: {
+      fromBase64,
+      fromHex,
+    },
+    WebAssembly,
+  }) {
+    _AsyncDisposableStack = AsyncDisposableStack;
+    _DisposableStack = DisposableStack;
+    _Float16Array = Float16Array;
+    _Intl = Intl;
+    _Iterator = Iterator;
+    _ShadowRealm = ShadowRealm;
+    _SharedArrayBuffer = SharedArrayBuffer;
+    _Temporal = Temporal;
+    _Uint8ArrayFromBase64 = fromBase64;
+    _Uint8ArrayFromHex = fromHex;
+    _WebAssembly = WebAssembly;
+
+    delete this._init;
+  },
+};

lib/internal/process/pre_execution.js

@@ -107,6 +107,8 @@ function prepareExecution(options) {
 
   refreshRuntimeOptions();
 
+  require('internal/primordials_staging')._init?.(globalThis);
+
   // Patch the process object and get the resolved main entry point.
   const mainEntry = patchProcessObject(expandArgv1);
   setupTraceCategoryState();

lib/internal/util.js

@@ -46,8 +46,8 @@ const {
   SymbolPrototypeGetDescription,
   SymbolReplace,
   SymbolSplit,
-  globalThis,
 } = primordials;
+const stagingPrimordials = require('internal/primordials_staging');
 
 const {
   codes: {
@@ -246,7 +246,7 @@ function assertCrypto() {
 function assertTypeScript() {
   if (noTypeScript)
     throw new ERR_NO_TYPESCRIPT();
-  if (globalThis.WebAssembly === undefined)
+  if (stagingPrimordials.WebAssembly === undefined)
     throw new ERR_WEBASSEMBLY_NOT_SUPPORTED('TypeScript');
 }
 

lib/internal/util/comparisons.js

@@ -50,8 +50,10 @@ const {
   Uint8ClampedArray,
   WeakMap,
   WeakSet,
-  globalThis: { Float16Array },
 } = primordials;
+const {
+  Float16Array,
+} = require('internal/primordials_staging');
 
 const { compare } = internalBinding('buffer');
 const assert = require('internal/assert');

lib/v8.js

@@ -32,10 +32,10 @@ const {
   Uint32Array,
   Uint8Array,
   Uint8ClampedArray,
-  globalThis: {
-    Float16Array,
-  },
 } = primordials;
+const {
+  Float16Array,
+} = require('internal/primordials_staging');
 
 const { Buffer } = require('buffer');
 const {

test/parallel/test-bootstrap-modules.js

@@ -117,6 +117,7 @@ expected.beforePreExec = new Set([
   'NativeModule internal/net',
   'NativeModule internal/dns/utils',
   'NativeModule internal/modules/esm/get_format',
+  'NativeModule internal/primordials_staging',
 ]);
 
 expected.atRunTime = new Set([