updated logic for dot command evaluation

Author: SudhansuBandha

lib/repl.js

@@ -76,9 +76,9 @@ const {
   StringPrototypeCharAt,
   StringPrototypeEndsWith,
   StringPrototypeIncludes,
-  StringPrototypeIndexOf,
   StringPrototypeRepeat,
   StringPrototypeSlice,
+  StringPrototypeSplit,
   StringPrototypeStartsWith,
   StringPrototypeTrim,
   Symbol,
@@ -803,24 +803,19 @@ class REPLServer extends Interface {
       }
 
       // Check REPL keywords and empty lines against a trimmed line input.
-      const trimmedCmd = StringPrototypeTrim(cmd);
+      let trimmedCmd = StringPrototypeTrim(cmd);
 
       // Check to see if a REPL keyword was used. If it returns true,
       // display next prompt and return.
       if (trimmedCmd) {
-        // If condition validates for dot commands at the beginning of the line,
-        // or dot commands after some whitespace.
-        const isDotCommandAtStart = StringPrototypeCharAt(trimmedCmd, 0) === '.' &&
-                                    StringPrototypeCharAt(trimmedCmd, 1) !== '.';
-        const dotIndex = StringPrototypeIndexOf(trimmedCmd, '.');
-        const isDotCommandAfterWhitespace = dotIndex > 0 &&
-                                            StringPrototypeCharAt(trimmedCmd, dotIndex + 1) !== '.';
-        const matches = RegExpPrototypeExec(/(?:^|\s)\.([^\s]+)\s*(.*)$/, trimmedCmd);
-        const keyword = matches?.[1];
-        const rest = matches?.[2];
-        const isValidKeyword = keyword && ObjectKeys(self.commands).includes(keyword);
-        if ((isDotCommandAtStart || isDotCommandAfterWhitespace && isValidKeyword) &&
-            NumberIsNaN(NumberParseFloat(trimmedCmd))) {
+        const splitString = StringPrototypeSplit(trimmedCmd, '\r');
+        trimmedCmd = splitString[splitString.length - 1];
+        if (StringPrototypeCharAt(trimmedCmd, 0) === '.' &&
+          StringPrototypeCharAt(trimmedCmd, 1) !== '.' &&
+          NumberIsNaN(NumberParseFloat(trimmedCmd))) {
+          const matches = RegExpPrototypeExec(/^\.([^\s]+)\s*(.*)$/, trimmedCmd);
+          const keyword = matches?.[1];
+          const rest = matches?.[2];
           if (FunctionPrototypeCall(_parseREPLKeyword, self, keyword, rest) === true) {
             return;
           }

test/parallel/test-repl-multiline-dot-commands-execution.js

@@ -12,13 +12,18 @@ function runDotCommand(command, validate) {
   const { replServer, output } = startNewREPLServer();
 
   replServer.on('exit', common.mustCall());
+  replServer.write(`${command}\n`);
+  replServer.write('let testObj = {\n');
+  replServer.write(`${command}:"dummy-value"\n`);
+  replServer.write(`}`);
   replServer.write('function a() {\n');
   replServer.write('console.log("logging");\n');
+  replServer.write(`let value = testObj ${command} \n`);
+  replServer.write('console.log(value) \n');
   replServer.write(`${command}\n`);
   validate(replServer, output);
   replServer.write('arr = [1,\n');
-  replServer.write('console.log("logging");\n');
-  replServer.write(`${command}\n`);
+  replServer.write('consdole.log("logging");\n');
   validate(replServer, output);
   replServer.close();
 }