Skip to content

Commit 2ae7d88

Browse files
committed
fixup! lib: add lint rule to enforce use of kEmptyObject
1 parent 7c6ac6f commit 2ae7d88

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

tools/eslint-rules/avoid-prototype-pollution.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -233,14 +233,14 @@ module.exports = {
233233
});
234234
},
235235

236-
'AssignmentPattern[right.type="ObjectExpression"][right.properties.length=0]'(node) {
237-
context.report({
238-
node: node.right,
239-
message: 'Use kEmptyObject instead of declaring a new empty object, or define a __proto__ property',
240-
});
241-
},
242-
243-
'AssignmentPattern[right.type="ObjectExpression"][right.properties.length>0]'(node) {
236+
'AssignmentPattern[right.type="ObjectExpression"]'(node) {
237+
if (!node.right.properties.length) {
238+
context.report({
239+
node: node.right,
240+
message: 'Use kEmptyObject instead of declaring a new empty object, or define a __proto__ property',
241+
});
242+
return;
243+
}
244244
const propertyIsIdentifier = (p) => p.key.type === 'Identifier';
245245
if (node.left.type === 'ObjectPattern' &&
246246
node.left.properties.every(propertyIsIdentifier) &&

0 commit comments

Comments
 (0)