Skip to content

Commit 0ebb811

Browse files
committed
test: fix Linux debug skip in SEA test guard
process.config.variables.is_debug is only populated by the GN build flow (tools/generate_config_gypi.py), so on the gyp builds used by CI the guard never fired and SEA tests ran on Linux debug builds against the original intent. Switch to process.config.target_defaults.default_configuration === 'Debug', matching the pattern used in test/common/index.js. Fixes: #63749 Refs: #61483 Signed-off-by: Hyunwoo Gu <realization0327@gmail.com>
1 parent 4fbd689 commit 0ebb811

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

test/common/sea.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ function skipIfSingleExecutableIsNotSupported() {
2727
if (!['darwin', 'win32', 'linux'].includes(process.platform))
2828
common.skip(`Unsupported platform ${process.platform}.`);
2929

30-
if (process.platform === 'linux' && process.config.variables.is_debug === 1)
30+
if (process.platform === 'linux' && process.config.target_defaults?.default_configuration === 'Debug')
3131
common.skip('Running the resultant binary fails with `Couldn\'t read target executable"`.');
3232

3333
if (process.config.variables.node_shared)

0 commit comments

Comments
 (0)