You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(plugin-manager): address review feedback from @spiros132
(A) Replace all .replace("{placeholder}", value) string interpolation with
native tr(key, { placeholder: value }) API — 11 call-sites across two files:
AvailableTabContent.qml (3 sites):
- installPlugin(): panel.installing, panel.install-success, panel.install-error
- version display: panel.version-prefix concat → panel.version-display interpolation
InstalledTabContent.qml (8 sites):
- _addPluginToBar(): panel.already-on-bar, panel.add-to-bar-success
- uninstallDialog description binding: panel.uninstall-dialog-description
- uninstallPlugin(): panel.uninstalling, panel.uninstall-success, panel.uninstall-error
- update button onClicked: panel.install-success, panel.install-error
- version display: double version-prefix concat → panel.version-update interpolation;
single version-prefix concat → panel.version-display interpolation
New i18n keys added to all 17 locale files:
- panel.version-display: "v{version}"
- panel.version-update: "v{from} → v{to}"
(B) NTabView decision — Panel.qml left unchanged (StackLayout kept):
NTabView uses implicitHeight for sizing and slide animation. The plugin-manager
left column uses Layout.fillHeight: true with NScrollView children that have no
meaningful implicitHeight — NTabView would collapse to zero height and produce
broken animation. The existing NTabBar + StackLayout pattern is correct here.
- Bump version 1.0.0 → 1.0.1
0 commit comments