You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/workflows/code-quality.yml
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -257,7 +257,7 @@ jobs:
257
257
else
258
258
if echo "$line" | grep -E "^\+" >/dev/null; then
259
259
# Only new lines should be auto checked for this type of code quality
260
-
if echo "$line" | grep -E "(border(\.width)?|spacing|pointSize|radius|margin(s)?): [0-9]+" >/dev/null; then
260
+
if echo "$line" | grep -E "(border(\.width)?|spacing|pointSize|radius|margin(s)?): [1-9]+[0-9]*" >/dev/null; then
261
261
print_line "$h_priority" "$line_index" 'Do not use hardcoded values, always prefer to use the `Style` singleton instead' "$line"
262
262
issues=$((issues + 1))
263
263
fi
@@ -279,7 +279,7 @@ jobs:
279
279
print_line "$l_priority" "$line_index" 'When it comes to translations there is no need for fallback values. From: `pluginApi?.tr("example") || "value"`. To: `pluginApi?.tr("example")`' "$line"
280
280
issues=$((issues + 1))
281
281
fi
282
-
if echo "$line" | grep -E "(text|label|description): *(\"|').*(\"|')" >/dev/null; then
282
+
if echo "$line" | grep -E "(text|label|description): *(\"|').+(\"|')" >/dev/null; then
283
283
print_line "$h_priority" "$line_index" 'Use translations instead of hardcoded text. Instead of: `"Example Label"`. To: `pluginApi?.tr("panel.example-label")`' "$line"
0 commit comments