Added translations. + Removed redundant logic.

Author: DaBenjle

dmenu/Main.qml

@@ -152,8 +152,8 @@ Item {
             || manifest.resultFile
             || "/tmp/noctalia-dmenu-result";
         cfg.resultFormat = overrides.resultFormat || "plain";
-        cfg.allowCustomInput = overrides.allowCustomInput === true ? true : false;
-        cfg.closeOnSelect = overrides.closeOnSelect === false ? false : true;
+        cfg.allowCustomInput = overrides.allowCustomInput;
+        cfg.closeOnSelect = overrides.closeOnSelect;
         cfg.maxResults = overrides.maxResults
             || defaults.maxResults
             || manifest.maxResults
@@ -231,8 +231,7 @@ Item {
         var resultStr = formatResult(value, index);
         var resultFile = state.resultFile;
         var callbackCmd = state.callbackCmd;
-        var showToast = pluginApi
-            ? (pluginApi.pluginSettings.showToastOnSelect || false) : false;
+        var showToast = pluginApi?.pluginSettings?.showToastOnSelect ?? false;
         var shouldClose = state.closeOnSelect;
 
         // Capture item name BEFORE endSession clears items

dmenu/Panel.qml

@@ -238,7 +238,7 @@ FocusScope {
                 fontSize: Style.fontSizeM
                 placeholderText: {
                     var st = root.dmenuState;
-                    return (st && st.prompt) ? st.prompt : "Type to filter...";
+                    return (st && st.prompt) ? st.prompt : root.pluginApi?.tr("provider.typeToFilterPlaceholder");
                 }
                 text: root.filterText
                 onTextChanged: root.filterText = text
@@ -388,9 +388,9 @@ FocusScope {
                     visible: root.filteredItems.length === 0
                     text: {
                         var st = root.dmenuState;
-                        if (!st || !st.active) return "Loading...";
-                        if (root.filterText !== "") return "No matches";
-                        return "No items";
+                        if (!st || !st.active) return root.pluginApi?.tr("provider.loading");
+                        if (root.filterText !== "") return root.pluginApi?.tr("provider.noMatches");
+                        return root.pluginApi?.tr("provider.noItems");
                     }
                     pointSize: Style.fontSizeM
                     color: Color.mOnSurfaceVariant
@@ -407,13 +407,27 @@ FocusScope {
                     Layout.fillWidth: true
                     text: {
                         if (root.filteredItems.length === 0) {
-                            if (root.filterText) return "No results";
+                            if (root.filterText) return root.pluginApi?.tr("provider.noResults");
                             return "";
                         }
-                        var prefix = "";
-                        if (root.filterText && root.showMatchCount)
-                            prefix = root.filteredItems.length + " of " + (root.dmenuState ? root.dmenuState.items.length : 0) + " · ";
-                        return prefix + root.filteredItems.length + " result" + (root.filteredItems.length !== 1 ? "s" : "");
+                        if (root.filterText && root.showMatchCount) {
+                            return root.pluginApi?.trp(
+                                "provider.filteredResultsCount",
+                                root.filteredItems.length,
+                                "{filtered} of {total} · {count} result",
+                                "{filtered} of {total} · {count} results",
+                                {
+                                    filtered: root.filteredItems.length,
+                                    total: root.dmenuState ? root.dmenuState.items.length : 0
+                                }
+                            );
+                        }
+                        return root.pluginApi?.trp(
+                            "provider.resultsCount",
+                            root.filteredItems.length,
+                            "{count} result",
+                            "{count} results"
+                        );
                     }
                     pointSize: Style.fontSizeXS
                     color: Color.mOnSurfaceVariant

dmenu/README.md

@@ -6,27 +6,6 @@ A dmenu replacement plugin for [Noctalia Shell](https://github.com/noctalia-dev/
 
 Everything is driven by Noctalia's IPC system. A script calls `showItems` or `showJson` to open the panel with a list of choices. When the user selects one, the plugin writes the result to a file and optionally runs a callback command. The included `noctalia-dmenu` helper script wraps this into a familiar pipe interface — under the hood it sends the IPC call, waits for the result file, and prints the selection to stdout.
 
-## Install
-
-```bash
-cd ~/.config/noctalia/plugins/
-git clone https://github.com/DaBenjle/noctalia-plugin-dmenu dmenu
-```
-
-Add to `~/.config/noctalia/plugins.json`:
-
-```json
-{ "states": { "dmenu": { "enabled": true } } }
-```
-
-Restart Noctalia, enable in Settings → Plugins.
-
-For pipe-style usage:
-
-```bash
-ln -s ~/.config/noctalia/plugins/dmenu/noctalia-dmenu ~/.local/bin/noctalia-dmenu
-```
-
 ## API
 
 All commands go through `noctalia-shell ipc call plugin:dmenu <method> [args]`.
@@ -74,36 +53,36 @@ noctalia-shell ipc call plugin:dmenu showFromFile /tmp/items.txt '{"separator":"
 
 ### Item fields
 
-| Field | Type | Description |
-|-------|------|-------------|
-| `name` | string | Display text |
-| `value` | string | Return value (defaults to `name`) |
-| `description` | string | Subtitle |
-| `icon` | string | [Tabler icon](https://tabler.io/icons) name |
-| `image` | string | Absolute path to image (overrides `icon`) |
+| Field         | Type   | Description                                 |
+| ------------- | ------ | ------------------------------------------- |
+| `name`        | string | Display text                                |
+| `value`       | string | Return value (defaults to `name`)           |
+| `description` | string | Subtitle                                    |
+| `icon`        | string | [Tabler icon](https://tabler.io/icons) name |
+| `image`       | string | Absolute path to image (overrides `icon`)   |
 
 ### Options
 
 For `showItems` / `showFromFile`, pass as second arg. For `showJson`, include in the same object.
 
-| Field | Type | Default | Description |
-|-------|------|---------|-------------|
-| `separator` | string | `"\n"` | Item delimiter (`showItems` / `showFromFile` text mode) |
-| `prompt` | string | `""` | Search bar placeholder |
-| `callbackCmd` | string | `""` | Run on selection. `{}` = value, `{index}` = index, `{name}` = name |
-| `resultFile` | string | `/tmp/noctalia-dmenu-result` | Where to write the result |
-| `resultFormat` | string | `"plain"` | `"plain"`, `"json"`, or `"index"` |
-| `allowCustomInput` | bool | `false` | Allow typing values not in the list |
-| `closeOnSelect` | bool | `true` | Close after selection |
-| `maxResults` | int | `200` | Max displayed items |
+| Field              | Type   | Default                      | Description                                                        |
+| ------------------ | ------ | ---------------------------- | ------------------------------------------------------------------ |
+| `separator`        | string | `"\n"`                       | Item delimiter (`showItems` / `showFromFile` text mode)            |
+| `prompt`           | string | `""`                         | Search bar placeholder                                             |
+| `callbackCmd`      | string | `""`                         | Run on selection. `{}` = value, `{index}` = index, `{name}` = name |
+| `resultFile`       | string | `/tmp/noctalia-dmenu-result` | Where to write the result                                          |
+| `resultFormat`     | string | `"plain"`                    | `"plain"`, `"json"`, or `"index"`                                  |
+| `allowCustomInput` | bool   | `false`                      | Allow typing values not in the list                                |
+| `closeOnSelect`    | bool   | `true`                       | Close after selection                                              |
+| `maxResults`       | int    | `200`                        | Max displayed items                                                |
 
 ### Other commands
 
-| Command | Description |
-|---------|-------------|
+| Command  | Description              |
+| -------- | ------------------------ |
 | `toggle` | Toggle panel open/closed |
-| `close` | Cancel and close |
-| `clear` | Reset state |
+| `close`  | Cancel and close         |
+| `clear`  | Reset state              |
 
 ## Helper script
 
@@ -121,17 +100,17 @@ noctalia-dmenu -f /tmp/items.txt -p "Select:"
 echo -e "Firefox\nChromium" | noctalia-dmenu -cb "gtk-launch {}"
 ```
 
-| Flag | Description |
-|------|-------------|
-| `-p`, `--prompt` | Search bar placeholder |
-| `-cb`, `--callback` | Command on selection |
-| `-c`, `--custom` | Allow custom input |
-| `-s`, `--separator` | Delimiter (default: newline) |
-| `-t`, `--timeout` | Wait timeout (default: 30s) |
-| `-r`, `--result-file` | Override result path |
-| `-f`, `--file` | Read from file |
-| `-F`, `--format` | Output: plain, json, index |
-| `-no-close` | Keep panel open |
+| Flag                  | Description                  |
+| --------------------- | ---------------------------- |
+| `-p`, `--prompt`      | Search bar placeholder       |
+| `-cb`, `--callback`   | Command on selection         |
+| `-c`, `--custom`      | Allow custom input           |
+| `-s`, `--separator`   | Delimiter (default: newline) |
+| `-t`, `--timeout`     | Wait timeout (default: 30s)  |
+| `-r`, `--result-file` | Override result path         |
+| `-f`, `--file`        | Read from file               |
+| `-F`, `--format`      | Output: plain, json, index   |
+| `-no-close`           | Keep panel open              |
 
 Exit: `0` selected, `1` timeout/cancelled, `2` error.
 
@@ -157,14 +136,14 @@ esac
 
 Settings → Plugins → Dmenu Provider → Configure.
 
-| Setting | Default | Description |
-|---------|---------|-------------|
-| Panel position | Follow launcher | Where the panel appears |
-| Show match count | On | Filtered/total in footer |
-| Show footer | On | Result count bar |
-| Show toast | Off | Notification on selection |
-| Result file | `/tmp/noctalia-dmenu-result` | Default path |
-| Max results | 200 | Display cap |
+| Setting          | Default                      | Description               |
+| ---------------- | ---------------------------- | ------------------------- |
+| Panel position   | Follow launcher              | Where the panel appears   |
+| Show match count | On                           | Filtered/total in footer  |
+| Show footer      | On                           | Result count bar          |
+| Show toast       | Off                          | Notification on selection |
+| Result file      | `/tmp/noctalia-dmenu-result` | Default path              |
+| Max results      | 200                          | Display cap               |
 
 ## Testing
 

dmenu/Settings.qml

@@ -136,7 +136,7 @@ ColumnLayout {
         spacing: Style.marginS
 
         NLabel {
-            label: root.pluginApi?.tr("settings.maxResults") + ": " + root.editMaxResults
+            label: root.pluginApi?.tr("settings.maxResultsLabel", { count: root.editMaxResults })
             description: root.pluginApi?.tr("settings.maxResultsDesc", { count: root.editMaxResults })
         }
 

dmenu/i18n/en.json

@@ -2,8 +2,17 @@
   "provider": {
     "name": "Dmenu",
     "command": "External menu (dmenu mode)",
+    "loading": "Loading...",
+    "noMatches": "No matches",
+    "noItems": "No items",
     "noSession": "No active dmenu session",
     "noSessionDesc": "Use IPC or noctalia-dmenu script to send items",
+    "noResults": "No results",
+    "filteredResultsCount": "{filtered} of {total} · {count} result",
+    "filteredResultsCount_plural": "{filtered} of {total} · {count} results",
+    "resultsCount": "{count} result",
+    "resultsCount_plural": "{count} results",
+    "typeToFilterPlaceholder": "Type to filter...",
     "customInput": "Use as custom input",
     "customInputHint": "✎  Custom input allowed — type anything and press Enter",
     "selected": "Selected: {value}"
@@ -40,6 +49,7 @@
     "showToast": "Show toast on select",
     "showToastDesc": "Display a notification when an item is selected",
     "maxResults": "Max results",
+    "maxResultsLabel": "Max results: {count}",
     "maxResultsDesc": "Maximum number of items to display: {count}"
   }
 }