Skip to content

Commit 385e5c7

Browse files
committed
Fix automatic code review
1 parent 2adcc69 commit 385e5c7

2 files changed

Lines changed: 14 additions & 15 deletions

File tree

slowbongo/Settings.qml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ ColumnLayout {
209209

210210
// Requirements Section
211211
Text {
212-
text: pluginApi?.tr("settings.requirements") || "Requirements"
212+
text: pluginApi?.tr("settings.requirements")
213213
color: Color.mOnSurface
214214
font.pointSize: Style.fontSizeM
215215
font.weight: Font.DemiBold
@@ -236,8 +236,8 @@ ColumnLayout {
236236
}
237237
Text {
238238
text: root.evtestInstalled
239-
? (pluginApi?.tr("settings.evtest-installed") || "evtest is installed")
240-
: (pluginApi?.tr("settings.evtest-not-installed") || "evtest is not installed")
239+
? pluginApi?.tr("settings.evtest-installed")
240+
: pluginApi?.tr("settings.evtest-not-installed")
241241
color: root.evtestInstalled ? root.statusSuccessColor : root.statusErrorColor
242242
font.pointSize: Style.fontSizeM
243243
}
@@ -252,8 +252,8 @@ ColumnLayout {
252252
}
253253
Text {
254254
text: root.inInputGroup
255-
? (pluginApi?.tr("settings.in-input-group") || "User is in the input group")
256-
: (pluginApi?.tr("settings.not-in-input-group") || "User is not in the input group")
255+
? pluginApi?.tr("settings.in-input-group")
256+
: pluginApi?.tr("settings.not-in-input-group")
257257
color: root.inInputGroup ? root.statusSuccessColor : root.statusErrorColor
258258
font.pointSize: Style.fontSizeM
259259
}
@@ -267,15 +267,15 @@ ColumnLayout {
267267

268268
// Widget Color
269269
NColorChoice {
270-
label: pluginApi?.tr("settings.colours") || "Colours"
270+
label: pluginApi?.tr("settings.colours")
271271
currentKey: root.editCatColor
272272
onSelected: key => { root.editCatColor = key; }
273273
}
274274

275275
// Cat Size Section
276276
NValueSlider {
277277
Layout.fillWidth: true
278-
label: pluginApi?.tr("settings.cat-size") || "Cat Size"
278+
label: pluginApi?.tr("settings.cat-size")
279279
value: root.editCatSize
280280
from: 0.5
281281
to: 1.5
@@ -289,7 +289,7 @@ ColumnLayout {
289289
// Vertical Position Section
290290
NValueSlider {
291291
Layout.fillWidth: true
292-
label: pluginApi?.tr("settings.vertical-position") || "Vertical Position"
292+
label: pluginApi?.tr("settings.vertical-position")
293293
value: root.editCatOffsetY
294294
from: -0.39
295295
to: 0.61
@@ -302,26 +302,26 @@ ColumnLayout {
302302

303303
// Rave Mode
304304
NToggle {
305-
label: pluginApi?.tr("settings.rave-mode") || "Rave Mode"
306-
description: pluginApi?.tr("settings.rave-mode-desc") || "Change colors to the beat when music is playing"
305+
label: pluginApi?.tr("settings.rave-mode")
306+
description: pluginApi?.tr("settings.rave-mode-desc")
307307
checked: root.editRaveMode
308308
onToggled: checked => root.editRaveMode = checked
309309
defaultValue: pluginApi?.manifest?.metadata?.defaultSettings?.raveMode ?? false
310310
}
311311

312312
// Tappy Mode
313313
NToggle {
314-
label: pluginApi?.tr("settings.tappy-mode") || "Tappy Mode"
315-
description: pluginApi?.tr("settings.tappy-mode-desc") || "Make the cat tap along to the beat when music is playing"
314+
label: pluginApi?.tr("settings.tappy-mode")
315+
description: pluginApi?.tr("settings.tappy-mode-desc")
316316
checked: root.editTappyMode
317317
onToggled: checked => root.editTappyMode = checked
318318
defaultValue: pluginApi?.manifest?.metadata?.defaultSettings?.tappyMode ?? false
319319
}
320320

321321
// MPRIS Filtering
322322
NToggle {
323-
label: pluginApi?.tr("settings.mpris-filter") || "MPRIS Filtering"
324-
description: pluginApi?.tr("settings.mpris-filter-desc") || "Only react to audio when a non-blacklisted media player is playing (uses NoctalisShell audio blacklist)"
323+
label: pluginApi?.tr("settings.mpris-filter")
324+
description: pluginApi?.tr("settings.mpris-filter-desc")
325325
checked: root.editUseMprisFilter
326326
onToggled: checked => root.editUseMprisFilter = checked
327327
defaultValue: pluginApi?.manifest?.metadata?.defaultSettings?.useMprisFilter ?? false

slowbongo/manifest.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
"version": "0.8.0",
55
"minNoctaliaVersion": "3.6.0",
66
"author": "tui",
7-
"official": false,
87
"description": "A bongo cat that sits in your bar and slaps when you type.",
98
"license": "MIT",
109
"repository": "https://github.com/noctalia-dev/noctalia-plugins",

0 commit comments

Comments
 (0)