Skip to content

params_dict should enforce dtype on values #16

Description

@TK-21st

If a given node has a parameter value specified as int (like 'param': 123) instead of float (like 'param':123.),
if is passed into the kernel as integer type. However, if the CUDA kernel specifies that the input argument is a floating point variable (like double), the parameter value will be set to cast to floating type with value 0.

In my opinion, in NDComponent __init__, params_dict should enforce a uniform dtype on the parameter values.
Or if there is a way to check the expected dtype from the cuda kernel in the pre_run stage and, if inconsistent between params_dict and the expected dtypes from the kernel, send a warning and convert to the one required by the kernel.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions