Skip to content

Remove unused code in Socket #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josesimoes merged 1 commit into from
Apr 7, 2026
Merged

Remove unused code in Socket #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions nanoFramework.System.Net/Sockets/Socket.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,6 @@ public class Socket : IDisposable
[Diagnostics.DebuggerBrowsable(Diagnostics.DebuggerBrowsableState.Never)]
private SocketType _socketType = SocketType.Unknown;

// Our internal state doesn't automatically get updated after a non-blocking connect
// completes. Keep track of whether we're doing a non-blocking connect, and make sure
// to poll for the real state until we're done connecting.
[Diagnostics.DebuggerBrowsable(Diagnostics.DebuggerBrowsableState.Never)]
private bool _nonBlockingConnectInProgress;

// Keep track of the kind of endpoint used to do a non-blocking connect, so we can set
// it to m_RightEndPoint when we discover we're connected.
[Diagnostics.DebuggerBrowsable(Diagnostics.DebuggerBrowsableState.Never)]
private EndPoint _nonBlockingConnectRightEndPoint;

// _rightEndPoint is null if the socket has not been bound. Otherwise, it is any EndPoint of the correct type (IPEndPoint, etc).
[Diagnostics.DebuggerBrowsable(Diagnostics.DebuggerBrowsableState.Never)]
internal EndPoint _rightEndPoint;
Expand Down Expand Up @@ -344,18 +333,6 @@ public void Connect(EndPoint remoteEP)
EndPoint endPointSnapshot = remoteEP;
Snapshot(ref endPointSnapshot);

if (m_fBlocking)
{
// blocking connect
_nonBlockingConnectInProgress = false;
}
else
{
// non blocking connect
_nonBlockingConnectInProgress = true;
_nonBlockingConnectRightEndPoint = endPointSnapshot;
}

NativeSocket.connect(this, endPointSnapshot, !m_fBlocking);

if (m_fBlocking)
Expand Down
Loading