From 4d10066e0439415c6c1ad83e9095f455415727fb Mon Sep 17 00:00:00 2001 From: Pedro Acebes Date: Mon, 8 Jun 2026 20:06:58 +0200 Subject: [PATCH] Fix #24075 new members of the castilian dulzaina instrument pitched in different key: F and G --- share/instruments/instruments.xml | 44 ++++++++++++++++++- share/instruments/instrumentsxml.h | 22 ++++++++++ .../mapping/windssetupdataresolver.cpp | 2 + 3 files changed, 66 insertions(+), 2 deletions(-) diff --git a/share/instruments/instruments.xml b/share/instruments/instruments.xml index 9cc0cdeff730d..ff9fe9e254676 100644 --- a/share/instruments/instruments.xml +++ b/share/instruments/instruments.xml @@ -1537,6 +1537,26 @@ world + + dulzainas + Castilian Dulzaina + Castilian Dulzaina + Cast. Dulz. + F + Spanish double-reed folk instrument from the Castile region. In F. + wind.reed.dulzaina + G + 1 + 62-86 + 62-91 + 3 + 5 + + + + + world + dulzainas Castilian Dulzaina @@ -1547,8 +1567,8 @@ wind.reed.dulzaina G 1 - 63-91 - 63-96 + 63-87 + 63-92 3 6 @@ -1557,6 +1577,26 @@ world + + dulzainas + Castilian Dulzaina + Castilian Dulzaina + Cast. Dulz. + G + Spanish double-reed folk instrument from the Castile region. In G. + wind.reed.dulzaina + G + 1 + 64-88 + 64-93 + 4 + 7 + + + + + world + oboes Piccolo Heckelphone diff --git a/share/instruments/instrumentsxml.h b/share/instruments/instrumentsxml.h index c86c01cafe1ba..66f7b833149c8 100644 --- a/share/instruments/instrumentsxml.h +++ b/share/instruments/instrumentsxml.h @@ -815,6 +815,17 @@ QT_TRANSLATE_NOOP3("engraving/instruments", "D Qn.", "d-quena shortName"), //: traitName for Quena; tuning: D; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names QT_TRANSLATE_NOOP3("engraving/instruments", "D", "d-quena traitName"), +//: description for Castilian Dulzaina; transposition: F; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names +QT_TRANSLATE_NOOP3("engraving/instruments", "Spanish double-reed folk instrument from the Castile region. In F.", "f-castilian-dulzaina description"), +//: trackName for Castilian Dulzaina; transposition: F; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names +QT_TRANSLATE_NOOP3("engraving/instruments", "Castilian Dulzaina", "f-castilian-dulzaina trackName"), +//: longName for Castilian Dulzaina; transposition: F; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names +QT_TRANSLATE_NOOP3("engraving/instruments", "Castilian Dulzaina", "f-castilian-dulzaina longName"), +//: shortName for Castilian Dulzaina; transposition: F; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names +QT_TRANSLATE_NOOP3("engraving/instruments", "Cast. Dulz.", "f-castilian-dulzaina shortName"), +//: traitName for Castilian Dulzaina; transposition: F; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names +QT_TRANSLATE_NOOP3("engraving/instruments", "F", "f-castilian-dulzaina traitName"), + //: description for Castilian Dulzaina; transposition: F♯; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names QT_TRANSLATE_NOOP3("engraving/instruments", "Spanish double-reed folk instrument from the Castile region. In F♯.", "fs-castilian-dulzaina description"), //: trackName for Castilian Dulzaina; transposition: F♯; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names @@ -826,6 +837,17 @@ QT_TRANSLATE_NOOP3("engraving/instruments", "Cast. Dulz.", "fs-castilian-dulzain //: traitName for Castilian Dulzaina; transposition: F♯; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names QT_TRANSLATE_NOOP3("engraving/instruments", "F♯", "fs-castilian-dulzaina traitName"), +//: description for Castilian Dulzaina; transposition: G; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names +QT_TRANSLATE_NOOP3("engraving/instruments", "Spanish double-reed folk instrument from the Castile region. In G.", "g-castilian-dulzaina description"), +//: trackName for Castilian Dulzaina; transposition: G; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names +QT_TRANSLATE_NOOP3("engraving/instruments", "Castilian Dulzaina", "g-castilian-dulzaina trackName"), +//: longName for Castilian Dulzaina; transposition: G; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names +QT_TRANSLATE_NOOP3("engraving/instruments", "Castilian Dulzaina", "g-castilian-dulzaina longName"), +//: shortName for Castilian Dulzaina; transposition: G; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names +QT_TRANSLATE_NOOP3("engraving/instruments", "Cast. Dulz.", "g-castilian-dulzaina shortName"), +//: traitName for Castilian Dulzaina; transposition: G; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names +QT_TRANSLATE_NOOP3("engraving/instruments", "G", "g-castilian-dulzaina traitName"), + //: description for Piccolo Heckelphone; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names QT_TRANSLATE_NOOP3("engraving/instruments", "Very rare variant of the heckelphone in F, sounding a fourth higher than the oboe.", "piccolo-heckelphone description"), //: trackName for Piccolo Heckelphone; Please see https://github.com/musescore/MuseScore/wiki/Translating-instrument-names diff --git a/src/engraving/playback/mapping/windssetupdataresolver.cpp b/src/engraving/playback/mapping/windssetupdataresolver.cpp index 95852dd0ccbdd..c297011863d33 100644 --- a/src/engraving/playback/mapping/windssetupdataresolver.cpp +++ b/src/engraving/playback/mapping/windssetupdataresolver.cpp @@ -102,7 +102,9 @@ PlaybackSetupData WindsSetupDataResolver::doResolve(const Instrument* instrument { "f-quena", { SoundId::Quena, SoundCategory::Winds } }, { "d-quena", { SoundId::Quena, SoundCategory::Winds } }, + { "f-castilian-dulzaina", { SoundId::Dulzaina, SoundCategory::Winds, { SoundSubCategory::Castilian } } }, { "fs-castilian-dulzaina", { SoundId::Dulzaina, SoundCategory::Winds, { SoundSubCategory::Castilian } } }, + { "g-castilian-dulzaina", { SoundId::Dulzaina, SoundCategory::Winds, { SoundSubCategory::Castilian } } }, { "piccolo-heckelphone", { SoundId::Heckelphone, SoundCategory::Winds } }, { "heckelphone", { SoundId::Heckelphone, SoundCategory::Winds } },