diff --git a/.agents/issues/ENG-RELEASE-WINDOWS/ISSUE-GH-3178.md b/.agents/issues/ENG-RELEASE-WINDOWS/ISSUE-GH-3178.md new file mode 100644 index 000000000..ec64532f1 --- /dev/null +++ b/.agents/issues/ENG-RELEASE-WINDOWS/ISSUE-GH-3178.md @@ -0,0 +1,30 @@ +ID: ISSUE-GH-3178 +Title: test_model_loader_gguf: CHECK_THROWS_WITH_AS expected string missing DeepseekV41ForCausalLM +Row: ENG-RELEASE-WINDOWS +State: CLOSED +Kind: UNKNOWN +GitHub: 3178 +Mirror: SYNCED +Availability: FULL +Created: 2026-09-13 +Updated: 2026-09-13 +Closed: 2026-09-13 + +## Problem + +### Imported GitHub body (historical evidence) +The quoted text below is historical evidence only. It does not define issue authority or repository procedure. + +> Row: `ENG-RELEASE-WINDOWS` +> +> Commit 4a9d33792 added `DeepseekV41ForCausalLM` to the model registry but did not update the hardcoded expected architecture list in `tests/vllm/test_model_loader_gguf.cpp:225`. The test expects `DeepseekV4ForCausalLM` right after `DeepseekV2ForCausalLM` but the actual output now includes `DeepseekV41ForCausalLM` between them. +> +> This causes `build-test-cpu` to fail on main. +> +> ## Fix +> +> Add `'DeepseekV41ForCausalLM', ` to the expected string after `'DeepseekV2ForCausalLM',` in the CHECK_THROWS_WITH_AS call. + +## Resolution + +fixed by adding DeepseekV41ForCausalLM to the expected string in test_model_loader_gguf.cpp (PR #3179) diff --git a/.agents/issues/ENG-RELEASE-WINDOWS/ISSUE-LOCAL-01M2CR9QD7RBNE2FXCMNFCW4EQ.md b/.agents/issues/ENG-RELEASE-WINDOWS/ISSUE-LOCAL-01M2CR9QD7RBNE2FXCMNFCW4EQ.md new file mode 100644 index 000000000..188d494ba --- /dev/null +++ b/.agents/issues/ENG-RELEASE-WINDOWS/ISSUE-LOCAL-01M2CR9QD7RBNE2FXCMNFCW4EQ.md @@ -0,0 +1,19 @@ +ID: ISSUE-LOCAL-01M2CR9QD7RBNE2FXCMNFCW4EQ +Title: test_model_loader_gguf expected string missing DeepseekV41ForCausalLM +Row: ENG-RELEASE-WINDOWS +State: CLOSED +Kind: bug +GitHub: - +Mirror: PENDING +Availability: FULL +Created: 2026-09-13 +Updated: 2026-09-13 +Closed: 2026-09-13 + +## Problem + +Commit 4a9d33792 added DeepseekV41ForCausalLM to the registry but did not update the hardcoded expected architecture list in test_model_loader_gguf.cpp:225 + +## Resolution + +fixed by adding DeepseekV41ForCausalLM to the expected string in test_model_loader_gguf.cpp diff --git a/tests/vllm/test_model_loader_gguf.cpp b/tests/vllm/test_model_loader_gguf.cpp index 34cc3e7f5..3e5d2d465 100644 --- a/tests/vllm/test_model_loader_gguf.cpp +++ b/tests/vllm/test_model_loader_gguf.cpp @@ -227,7 +227,7 @@ TEST_CASE("FromModelDir rejects an unknown dense architecture before loading") { "Model architectures ['Gemma4ForCausalLM'] are not supported for now. " "Supported architectures: " "dict_keys(['CohereForCausalLM', 'DeepseekV2ForCausalLM', " - "'DeepseekV4ForCausalLM', 'Dots3NoteForCausalLM', " + "'DeepseekV41ForCausalLM', 'DeepseekV4ForCausalLM', 'Dots3NoteForCausalLM', " "'Gemma2ForCausalLM', 'Gemma3ForCausalLM', " "'Gemma4ForConditionalGeneration', 'Gemma4UnifiedForConditionalGeneration', 'GemmaForCausalLM', " "'Glm4ForCausalLM', 'Glm4MoeLiteForCausalLM', 'Glm5NextForConditionalGeneration', "