fix(executors/background): notify, don't error, on junit xml file read failure

Author: mrcjkb

lua/rustaceanvim/executors/background.lua

@@ -14,18 +14,22 @@ local M = {}
 ---@field test_id string
 
 ---@param path string
----@return string content
+---@return boolean success
+---@return string content_or_err
 local function read_file(path)
   local file_fd, open_err = vim.uv.fs_open(path, 'r', 438)
-  assert(not open_err, open_err)
-  assert(file_fd, 'expected file descriptor')
+  if not file_fd or open_err then
+    return false, open_err or ('expected file descriptor for ' .. path)
+  end
   local stat, stat_err = vim.uv.fs_fstat(file_fd)
-  assert(not stat_err, stat_err)
-  assert(stat, 'expected file stats')
+  if not stat or stat_err then
+    return false, stat_err or ('expected file stats for ' .. path)
+  end
   local data, read_err = vim.uv.fs_read(file_fd, stat.size, 0)
-  assert(data, 'expected file content')
-  assert(not read_err, read_err)
-  return data
+  if not data or read_err then
+    return false, read_err or ('expected file content for ' .. path)
+  end
+  return true, data
 end
 
 M.execute_command = function(command, args, cwd, opts)
@@ -57,12 +61,12 @@ M.execute_command = function(command, args, cwd, opts)
     if is_cargo_test then
       diagnostics = require('rustaceanvim.test').parse_cargo_test_diagnostics(output, opts.bufnr)
     else
-      local junit_xml = read_file((cwd or vim.fn.getcwd()) .. '/target/nextest/rustaceanvim/junit.xml')
-      if not junit_xml then
-        vim.notify('Failed to read junit.xml file', vim.log.levels.ERROR)
+      local ok, junit_xml_or_err = read_file((cwd or vim.fn.getcwd()) .. '/target/nextest/rustaceanvim/junit.xml')
+      if not ok then
+        vim.notify('Failed to read junit.xml file: ' .. junit_xml_or_err, vim.log.levels.ERROR)
         return
       end
-      diagnostics = require('rustaceanvim.test').parse_nextest_diagnostics(junit_xml, opts.bufnr)
+      diagnostics = require('rustaceanvim.test').parse_nextest_diagnostics(junit_xml_or_err, opts.bufnr)
     end
     local summary = get_test_summary(sc.stdout or '')
     vim.schedule(function()