From cb06c67e323d1e4abc41df6bc1a10d9314e68cda Mon Sep 17 00:00:00 2001 From: Reino Muhl <10620585+StaberindeZA@users.noreply.github.com> Date: Wed, 3 Jun 2026 16:26:12 -0400 Subject: [PATCH] fix(ci): checkout FxA code before setup-node in l10n-gettext-extract Because: - setup-node reads node-version-file from the runner filesystem at the time the step runs. In l10n-gettext-extract.yml the FxA repo is checked out into a 'fxa-code' subdirectory *after* setup-node, so '.nvmrc' did not exist on disk yet and setup-node failed with "Unable to locate '.nvmrc'". This commit: - Moves the "Clone FxA code repository" step ahead of "Set up Node" and points node-version-file at 'fxa-code/.nvmrc' so setup-node finds the file. The l10n repo checkout remains after setup-node since it is not needed for Node setup. --- .github/workflows/l10n-gettext-extract.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/l10n-gettext-extract.yml b/.github/workflows/l10n-gettext-extract.yml index dd9b63a9e90..2c84f855944 100644 --- a/.github/workflows/l10n-gettext-extract.yml +++ b/.github/workflows/l10n-gettext-extract.yml @@ -11,10 +11,16 @@ jobs: run: | sudo apt update sudo apt install gettext -y + - name: Clone FxA code repository + uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 + with: + fetch-depth: 2 + path: 'fxa-code' + persist-credentials: false - name: Set up Node uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6 with: - node-version-file: '.nvmrc' + node-version-file: 'fxa-code/.nvmrc' - name: Install global npm packages run: | yarn global add grunt-cli @@ -24,12 +30,6 @@ jobs: repository: mozilla/fxa-content-server-l10n path: 'fxa-l10n' persist-credentials: false - - name: Clone FxA code repository - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 - with: - fetch-depth: 2 - path: 'fxa-code' - persist-credentials: false - name: Install npm packages run: | cd fxa-l10n