[Bug]: Review Tools page exposes CinderPolicies regardless of entity type

[wagnerand-moz]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

The old ReviewActionReason had a dedicated field to specific which entity type a reason applies to. CinderPolicy doesn't seem to have that, so all policies are exposed regardless of the entity type. However, the majority of policies only apply to extensions, and a small set of policies apply to themes only.

How can we make sure we only show the policies on the review page that are relevant for that particular entity type?

What did you expect to happen?

The extension review page only shows policies relevant to extensions.
The theme review page only shows policies relevant to themes.

(And, since lots of our metrics, investigations, decision making and statistics is based on redash dashboards and queries, it would be helpful to have that entity type classifier for a policy in the database too.)

┆Issue is synchronized with this Jira Task

[diox]

Cinder has the notion of which queue a policy is applied on, which sort of hides the issue, but reviewer tools don't. Internally we have something to limit policies to entity types but the entity is Addon for both themes and extensions.

[diox]

@wagnerand-moz which policies from https://docs.google.com/document/d/1pRRDRyZ7fQi7a85Y6KIzOi0TtiJXSML13FTFqONNgoc/edit?pli=1&tab=t.0 would be available to themes and which ones would be available to extensions ? (Trying to determine how this should be represented on our end)

[wagnerand-moz]

@wagnerand-moz which policies from https://docs.google.com/document/d/1pRRDRyZ7fQi7a85Y6KIzOi0TtiJXSML13FTFqONNgoc/edit?pli=1&tab=t.0 would be available to themes and which ones would be available to extensions ? (Trying to determine how this should be represented on our end)

This might not be 100% accurate with the recent move from ReviewActionReason to CinderPolicy but can give some indication on the distribution of all vs extension vs theme: https://sql.telemetry.mozilla.org/queries/94406. Let me know if that is not what you are looking for.