Skip to content
This repository was archived by the owner on May 30, 2025. It is now read-only.
This repository was archived by the owner on May 30, 2025. It is now read-only.

Typing issues  #87

Description

@paulMery

1 TransferCreate type:

  • facilitatorFee, description, metadata should be optional.
  • in source and destination object: only paymentMethodID should be required.
    So it match the example here

    moov-node/lib/transfers.js

    Lines 259 to 280 in 5cb81da

    * @example
    * const moov = new Moov(...);
    * try {
    * const transfer = {
    * source: { paymentMethodID: "..." },
    * destination: { paymentMethodID: "..." },
    * amount: {
    * value: 3215, // $32.15
    * currency: "USD"
    * },
    * facilitatorFee: {
    * value: 8, // $0.8
    * currency: "USD"
    * },
    * description: "Yoga class"
    * };
    * const { transferID } = moov.transfers.create(transfer);
    * } catch (err) {
    * // ...
    * }
    *
    */

    as well as the API documentation

2 AccountCreate type:

  • metadata, termsOfService, foreignID, customerSupport, settings should be optional
  • mode : production | sandox is missing should be added as a required parameters as it's required in the API documentation.
  • in profile > IndividualProfile: Phone, Address, birthDateProvided, governmentIDProvided should be optional (with default values for the booleans)

3 API documentation

The api documentation (transfers/create section) is not matching the TransferCreate object. The transferID should be removed from the documentation as it's misleading or maybe we can create a transfer using another transfer but in that case I am not sure I understand.
image

Thanks ! 🙏

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions