Skip to content

Commit ea07f4b

Browse files
CLOUDP-368426-Stream-Workspace error codes standard
1 parent fa3433c commit ea07f4b

2 files changed

Lines changed: 21 additions & 2 deletions

File tree

cfn-resources/stream-workspace/cmd/resource/resource.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ func Read(req handler.Request, prevModel *Model, currentModel *Model) (handler.P
9090

9191
streamWorkspace, resp, err := conn.StreamsApi.GetStreamWorkspace(ctx, *currentModel.ProjectId, *currentModel.WorkspaceName).Execute()
9292
if err != nil {
93-
if resp != nil && resp.StatusCode == http.StatusNotFound {
93+
if util.StatusNotFound(resp) {
9494
return handler.ProgressEvent{
9595
OperationStatus: handler.Failed,
9696
Message: "StreamWorkspace not found",
@@ -120,7 +120,7 @@ func Update(req handler.Request, prevModel *Model, currentModel *Model) (handler
120120
streamWorkspaceUpdateReq := NewStreamWorkspaceUpdateReq(currentModel)
121121
updatedStreamWorkspace, resp, err := conn.StreamsApi.UpdateStreamWorkspace(ctx, *currentModel.ProjectId, *currentModel.WorkspaceName, streamWorkspaceUpdateReq).Execute()
122122
if err != nil {
123-
if resp != nil && resp.StatusCode == http.StatusNotFound {
123+
if util.StatusNotFound(resp) {
124124
return handler.ProgressEvent{
125125
OperationStatus: handler.Failed,
126126
Message: "StreamWorkspace not found",

cfn-resources/util/http_status.go

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
package util
2+
3+
import "net/http"
4+
5+
func StatusNotFound(resp *http.Response) bool {
6+
return resp != nil && resp.StatusCode == http.StatusNotFound
7+
}
8+
9+
func StatusConflict(resp *http.Response) bool {
10+
return resp != nil && resp.StatusCode == http.StatusConflict
11+
}
12+
13+
func StatusBadRequest(resp *http.Response) bool {
14+
return resp != nil && resp.StatusCode == http.StatusBadRequest
15+
}
16+
17+
func StatusServiceUnavailable(resp *http.Response) bool {
18+
return resp != nil && resp.StatusCode == http.StatusServiceUnavailable
19+
}

0 commit comments

Comments
 (0)