Add contract testing workflow, use http util functions

Author: outcomes-winter-rakhulsprakash

.github/workflows/contract-testing.yaml

@@ -15,6 +15,7 @@ jobs:
      alert-configuration: ${{ steps.filter.outputs.alert-configuration }}
      api-key: ${{ steps.filter.outputs.api-key }}
      auditing: ${{ steps.filter.outputs.auditing }}
+     backup-compliance-policy: ${{ steps.filter.outputs.backup-compliance-policy }}
      cloud-backup-restore-jobs: ${{ steps.filter.outputs.cloud-backup-restore-jobs }}
      cluster-outage-simulation: ${{ steps.filter.outputs.cluster-outage-simulation }}
      federated-database-instance: ${{ steps.filter.outputs.federated-database-instance }}
@@ -46,6 +47,8 @@ jobs:
           - 'cfn-resources/api-key/**'
         auditing:
           - 'cfn-resources/auditing/**'
+        backup-compliance-policy:
+          - 'cfn-resources/backup-compliance-policy/**'
         cloud-backup-restore-jobs:
           - 'cfn-resources/cloud-backup-restore-jobs/**'
         cluster-outage-simulation:
@@ -237,7 +240,48 @@ jobs:
        cat inputs/inputs_1_update.json
        cat inputs/inputs_2_create.json
        cat inputs/inputs_2_update.json
-       
+
+       make run-contract-testing
+       make delete-test-resources
+  backup-compliance-policy:
+    needs: change-detection
+    if: ${{ needs.change-detection.outputs.backup-compliance-policy == 'true' }}
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
+    - uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5
+      with:
+        go-version-file: 'cfn-resources/go.mod'
+    - name: setup Atlas CLI
+      uses: mongodb/atlas-github-action@e3c9e0204659bafbb3b65e1eb1ee745cca0e9f3b
+    - uses: aws-actions/setup-sam@c2a20b1822cc4a6bc594ff7f1dbb658758e383c3
+      with:
+       use-installer: true
+    - uses: aws-actions/configure-aws-credentials@61815dcd50bd041e203e49132bacad1fd04d2708
+      with:
+        aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID_TEST_ENV }}
+        aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY_TEST_ENV }}
+        aws-region: eu-west-1
+    - uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548
+      with:
+        python-version: '3.9'
+        cache: 'pip' # caching pip dependencies
+    - run: pip install cloudformation-cli cloudformation-cli-go-plugin
+    - name: Run the Contract test
+      shell: bash
+      env:
+       MONGODB_ATLAS_PUBLIC_API_KEY: ${{ secrets.CLOUD_DEV_PUBLIC_KEY }}
+       MONGODB_ATLAS_PRIVATE_API_KEY: ${{ secrets.CLOUD_DEV_PRIVATE_KEY }}
+       MONGODB_ATLAS_ORG_ID: ${{ secrets.CLOUD_DEV_ORG_ID }}
+       MONGODB_ATLAS_OPS_MANAGER_URL: ${{ vars.MONGODB_ATLAS_BASE_URL }}
+       MONGODB_ATLAS_PROFILE: cfn-cloud-dev-github-action
+      run: |
+       cd cfn-resources/backup-compliance-policy
+       make create-test-resources
+
+       cat inputs/inputs_1_create.json
+       cat inputs/inputs_1_update.json
+
        make run-contract-testing
        make delete-test-resources
   cloud-backup-restore-jobs:

cfn-resources/backup-compliance-policy/Makefile

@@ -20,7 +20,11 @@ clean:
 
 create-test-resources:
 	@echo "==> Creating test files for contract testing"
-	./test/contract-testing/cfn-test-create-inputs.sh
+	./test/contract-testing/cfn-test-create.sh
+
+delete-test-resources:
+	@echo "==> Delete test resources used for contract testing"
+	./test/contract-testing/cfn-test-delete.sh
 
 run-contract-testing:
 	@echo "==> Run contract testing"

…-compliance-policy/cmd/resource/share.go …mpliance-policy/cmd/resource/handlers.gocfn-resources/backup-compliance-policy/cmd/resource/share.go renamed to cfn-resources/backup-compliance-policy/cmd/resource/handlers.go cfn-resources/backup-compliance-policy/cmd/resource/share.go renamed to cfn-resources/backup-compliance-policy/cmd/resource/handlers.go

@@ -60,7 +60,7 @@ func handlePendingAction(ctx context.Context, client *util.MongoDBClient, model
 
 func checkPolicyNotFound(policy *admin.DataProtectionSettings20231001, apiResp *http.Response, err error, projectID string, operation constants.CfnFunctions) *handler.ProgressEvent {
 	if err != nil {
-		if apiResp != nil && apiResp.StatusCode == http.StatusNotFound {
+		if util.StatusNotFound(apiResp) {
 			pe := progress_events.GetFailedEventByCode(
 				"Backup Compliance Policy not found for project: "+projectID,
 				string(types.HandlerErrorCodeNotFound))
@@ -90,7 +90,7 @@ func HandleCreate(req *handler.Request, client *util.MongoDBClient, model *Model
 
 	existingPolicy, apiResp, err := client.AtlasSDK.CloudBackupsApi.GetCompliancePolicy(ctx, projectID).Execute()
 	if err != nil {
-		if apiResp == nil || apiResp.StatusCode != http.StatusNotFound {
+		if !util.StatusNotFound(apiResp) {
 			return handleError(apiResp, constants.CREATE, err)
 		}
 	} else if existingPolicy != nil && existingPolicy.GetState() == policyStateActive {
@@ -210,7 +210,7 @@ func HandleDelete(req *handler.Request, client *util.MongoDBClient, model *Model
 		return handlePendingAction(ctx, client, model, projectID)
 	}
 
-	if apiResp != nil && apiResp.StatusCode == http.StatusNotFound {
+	if util.StatusNotFound(apiResp) {
 		return handler.ProgressEvent{
 			OperationStatus: handler.Success,
 			Message:         constants.Complete,
@@ -227,7 +227,7 @@ func HandleList(req *handler.Request, client *util.MongoDBClient, model *Model)
 
 	policy, apiResp, err := client.AtlasSDK.CloudBackupsApi.GetCompliancePolicy(ctx, projectID).Execute()
 	if err != nil {
-		if apiResp == nil || apiResp.StatusCode != http.StatusNotFound {
+		if !util.StatusNotFound(apiResp) {
 			return handleError(apiResp, constants.LIST, err)
 		}
 		return handler.ProgressEvent{
@@ -274,7 +274,7 @@ func validateProgress(client *util.MongoDBClient, model *Model, isDelete bool) h
 	projectID := *model.ProjectId
 
 	policy, resp, err := client.AtlasSDK.CloudBackupsApi.GetCompliancePolicy(ctx, projectID).Execute()
-	notFound := resp != nil && resp.StatusCode == http.StatusNotFound
+	notFound := util.StatusNotFound(resp)
 	policyDeleted := notFound || (policy != nil && policy.GetProjectId() == "")
 
 	if err != nil && !notFound {