Fixed types

Author: mongkok

debug_toolbar/panels/logging.py

@@ -24,20 +24,27 @@ def __init__(self) -> None:
             )
         self.collections: t.Dict[int, t.List[t.Dict[str, t.Any]]] = {}
 
-    def get_collection(self, thread_id: int = None) -> t.List[t.Dict[str, t.Any]]:
+    def get_collection(
+        self,
+        thread_id: t.Optional[int] = None,
+    ) -> t.List[t.Dict[str, t.Any]]:
         if thread_id is None:
             thread_id = threading.get_ident()
         if thread_id not in self.collections:
             self.collections[thread_id] = []
         return self.collections[thread_id]
 
-    def clear_collection(self, thread_id: int = None) -> None:
+    def clear_collection(self, thread_id: t.Optional[int] = None) -> None:
         if thread_id is None:
             thread_id = threading.get_ident()
         if thread_id in self.collections:
             del self.collections[thread_id]
 
-    def collect(self, item: t.Dict[str, t.Any], thread_id: int = None) -> None:
+    def collect(
+        self,
+        item: t.Dict[str, t.Any],
+        thread_id: t.Optional[int] = None,
+    ) -> None:
         self.get_collection(thread_id).append(item)
 
 

tests/testclient.py

@@ -2,7 +2,7 @@
 import typing as t
 from urllib import parse
 
-import requests
+import httpx
 from fastapi import status
 from fastapi.testclient import TestClient as BaseTestClient
 
@@ -11,7 +11,12 @@
 
 
 class TestClient(BaseTestClient):
-    def get_store_id(self, path: str, method: str = None, **kwargs: t.Any) -> str:
+    def get_store_id(
+        self,
+        path: str,
+        method: t.Optional[str] = None,
+        **kwargs: t.Any,
+    ) -> str:
         response = getattr(self, (method or "get"))(path, **kwargs)
 
         if response.headers["content-type"].startswith("text/html"):
@@ -20,7 +25,7 @@ def get_store_id(self, path: str, method: str = None, **kwargs: t.Any) -> str:
         cookie = parse.unquote(response.headers["set-cookie"])
         return re.findall(r'"storeId": "(.+?)"', cookie)[0]
 
-    def render_panel(self, store_id: str, panel_id: str) -> requests.Response:
+    def render_panel(self, store_id: str, panel_id: str) -> httpx.Response:
         url = self.app.url_path_for("debug_toolbar.render_panel")  # type: ignore
         return self.get(url, params={"store_id": store_id, "panel_id": panel_id})