Skip to content

Commit ad4a7ef

Browse files
committed
Improved ORM tests
1 parent 506e834 commit ad4a7ef

4 files changed

Lines changed: 14 additions & 9 deletions

File tree

tests/panels/sqlalchemy/conftest.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ def get_db() -> t.Generator:
2424
def client(app: FastAPI, get_index: t.Callable) -> TestClient:
2525
@app.get("/sql", response_class=HTMLResponse)
2626
async def get_sql(request: Request, db: Session = Depends(get_db)) -> str:
27-
create_user(db=db, username="test")
28-
get_user(db=db, user_id=1)
29-
get_user(db=db, user_id=1)
27+
user = create_user(db=db, username="test")
28+
get_user(db=db, user_id=user.id)
29+
get_user(db=db, user_id=user.id)
3030
return get_index(request)
3131

3232
return TestClient(app)
Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
from sqlalchemy import create_engine
22
from sqlalchemy.ext.declarative import declarative_base
33
from sqlalchemy.orm import sessionmaker
4+
from sqlalchemy.pool import StaticPool
45

5-
engine = create_engine("sqlite://", connect_args={"check_same_thread": False})
6+
engine = create_engine(
7+
"sqlite://",
8+
connect_args={"check_same_thread": False},
9+
poolclass=StaticPool,
10+
)
611
SessionLocal = sessionmaker(bind=engine)
712
Base = declarative_base()

tests/panels/sqlalchemy/test_sqlalchemy.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ def test_sqlalchemy(client: TestClient) -> None:
99
stats = client.get_stats(store_id, "SQLAlchemyPanel")
1010
queries = stats["queries"]
1111

12-
assert len(queries) == 3
12+
assert len(queries) == 4
1313
assert queries[0][1]["sql"].startswith("INSERT")
14-
assert queries[1][1]["dup_count"] == 2
14+
assert queries[2][1]["dup_count"] == 2

tests/panels/tortoise/conftest.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ async def client(
1616
) -> t.AsyncGenerator[TestClient, None]:
1717
@app.get("/sql", response_class=HTMLResponse)
1818
async def get_sql(request: Request) -> str:
19-
await create_user(username="test")
20-
await get_user(user_id=1)
21-
await get_user(user_id=1)
19+
user = await create_user(username="test")
20+
await get_user(user_id=user.id)
21+
await get_user(user_id=user.id)
2222
return get_index(request)
2323

2424
await Tortoise.init(

0 commit comments

Comments
 (0)