Skip to content

Commit 7af8e6f

Browse files
author
mongkok
committed
Added generic skip_py mark
1 parent f995e27 commit 7af8e6f

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

tests/mark.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ def override_panels(panels: t.List[str]) -> MarkDecorator:
1313
return override_settings(panels=panels)
1414

1515

16-
skip_py37: MarkDecorator = pytest.mark.skipif(sys.version_info < (3, 8), reason="?")
17-
skip_py36: MarkDecorator = pytest.mark.skipif(sys.version_info < (3, 7), reason="?")
16+
def skip_py(*version: int) -> MarkDecorator:
17+
return pytest.mark.skipif(sys.version_info < version, reason="?")

tests/panels/sqlalchemy/test_sqlalchemy.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
from fastapi import status
22

3-
from ...mark import override_panels, skip_py36
3+
from ...mark import override_panels, skip_py
44
from ...testclient import TestClient
55

66

7-
@skip_py36
7+
@skip_py(3, 7)
88
@override_panels(["debug_toolbar.panels.sqlalchemy.SQLAlchemyPanel"])
99
def test_sqlalchemy(client: TestClient) -> None:
1010
store_id = client.get_store_id("/sql")

tests/panels/test_logging.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from fastapi.logger import logger
77
from fastapi.responses import HTMLResponse
88

9-
from ..mark import override_panels, skip_py37
9+
from ..mark import override_panels, skip_py
1010
from ..testclient import TestClient
1111

1212

@@ -25,7 +25,7 @@ async def get_log_async(request: Request, level: str) -> str:
2525

2626

2727
@pytest.mark.parametrize("level", ["ERROR", "WARNING"])
28-
@pytest.mark.parametrize("path", [pytest.param("sync", marks=skip_py37), "async"])
28+
@pytest.mark.parametrize("path", [pytest.param("sync", marks=skip_py(3, 8)), "async"])
2929
@override_panels(["debug_toolbar.panels.logging.LoggingPanel"])
3030
def test_logging(client: TestClient, path: str, level: str) -> None:
3131
store_id = client.get_store_id(f"/log/{path}?level={level}")

0 commit comments

Comments
 (0)