Skip to content

Commit 6db2a6d

Browse files
authored
Prevent desktop release build jobs from auto-publishing (#16)
1 parent 828553b commit 6db2a6d

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

.github/workflows/desktop-release.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,13 +170,13 @@ jobs:
170170
include:
171171
- name: macOS
172172
os: macos-latest
173-
command: bun run dist:mac
173+
command: bun run dist:mac:no-publish
174174
- name: Windows
175175
os: windows-latest
176-
command: bun run dist:win
176+
command: bun run dist:win:no-publish
177177
- name: Linux
178178
os: ubuntu-22.04
179-
command: bun run dist:linux
179+
command: bun run dist:linux:no-publish
180180

181181
steps:
182182
- name: Check out source
@@ -319,6 +319,9 @@ jobs:
319319
append_env "SENTRY_ELECTRON_INGEST_URL" "$SENTRY_ELECTRON_INGEST_URL_SECRET"
320320
321321
- name: Build desktop installer
322+
# Build jobs only produce artifacts. The publish job below owns GitHub
323+
# Release creation/upload so dry-run, draft, prerelease, and replace
324+
# behavior stays centralized.
322325
run: ${{ matrix.command }}
323326

324327
- name: Upload installer artifacts

package.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@
3737
"dist:mac": "bun run electron:dist:mac",
3838
"dist:win": "bun run electron:dist:win",
3939
"dist:linux": "bun run electron:dist:linux",
40+
"dist:mac:no-publish": "bun run electron:dist:mac:no-publish",
41+
"dist:win:no-publish": "bun run electron:dist:win:no-publish",
42+
"dist:linux:no-publish": "bun run electron:dist:linux:no-publish",
4043
"test": "bun test && for f in $(find . -name '*.isolated.ts' -not -path './node_modules/*'); do bun test \"$f\" || exit 1; done",
4144
"typecheck": "bun run typecheck:shared",
4245
"typecheck:shared": "cd packages/shared && bun run tsc --noEmit",
@@ -89,6 +92,9 @@
8992
"electron:dist:mac": "bun run electron:vendor:qwen && bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --mac",
9093
"electron:dist:win": "bun run electron:vendor:qwen && bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --win",
9194
"electron:dist:linux": "bun run electron:vendor:qwen && bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --linux",
95+
"electron:dist:mac:no-publish": "bun run electron:vendor:qwen && bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --mac --publish never",
96+
"electron:dist:win:no-publish": "bun run electron:vendor:qwen && bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --win --publish never",
97+
"electron:dist:linux:no-publish": "bun run electron:vendor:qwen && bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --linux --publish never",
9298
"electron:dist:dev:mac": "bun run electron:vendor:qwen && CSC_IDENTITY_AUTO_DISCOVERY=false CRAFT_DEV_RUNTIME=1 bun run electron:build && bun run electron:builder-config && cd apps/electron && CSC_IDENTITY_AUTO_DISCOVERY=false electron-builder --config electron-builder.generated.yml --mac",
9399
"electron:dist:dev:win": "bun run electron:vendor:qwen && CRAFT_DEV_RUNTIME=1 bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --win",
94100
"electron:dist:dev:linux": "bun run electron:vendor:qwen && CRAFT_DEV_RUNTIME=1 bun run electron:build && bun run electron:builder-config && cd apps/electron && electron-builder --config electron-builder.generated.yml --linux",

0 commit comments

Comments
 (0)