Skip to content
This repository was archived by the owner on Jul 21, 2020. It is now read-only.
This repository was archived by the owner on Jul 21, 2020. It is now read-only.

Inconsistent Naming between oauth api and OAuth.ts #80

Description

@SReject

The property naming with OAuth.ts for the OAuthProvider constructor's options.tokens is inconsistent with what the OAuth api returns equating to the program having to do some middle-man-mutating of the api's response before calling the OAuth constructor.

API Uses OAuth.ts Uses
client_id clientId
client_secret secret
access_token access
refresh_token refresh
expires_in expires*

*) This is fine as the two names refer to two different pieces of data (API returns a number, OAuth.ts expects a ISO date string)

This is predominately only an issue with the setTokens() function. Since its called from the constructor it inhibits the user/app from passing an oauth api response directly into the constructor.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions