From 5f2e13de9388faef5fae2e728381106ec1bca6ff Mon Sep 17 00:00:00 2001 From: Paul Hinze Date: Thu, 23 Jul 2026 17:34:56 -0500 Subject: [PATCH] Fix distributed peer build failing on VCS stamping in CI The new test-blackbox-distributed job builds miren on each peer via `make bin/miren`, which iso peers runs as root. But /src is owned by the host user, so git's dubious-ownership check aborts `git status` (exit 128) and Go's build VCS stamping fails the whole build. The standalone dev flow (hack/dev.sh) sidesteps this by building as the host user; the peers path never reconciled that and builds as root. Mark /src a safe directory before building, the same fix hack/package-release.sh uses. --- hack/dev-distributed | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hack/dev-distributed b/hack/dev-distributed index f7e641945..27719f26e 100755 --- a/hack/dev-distributed +++ b/hack/dev-distributed @@ -29,6 +29,12 @@ bootstrap_peer() { echo " Bootstrapping $peer..." # Run the common setup (cgroups, kernel mounts, dirs, host user, etc.) peer_exec "$peer" bash -c "source hack/common-setup.sh && setup_cgroups && setup_environment && setup_host_user && setup_kernel_mounts" + # The build runs as root in the peer, but /src is owned by the host user, + # so git's dubious-ownership check aborts `git status` (exit 128) and Go's + # build VCS stamping fails the build. Unlike the standalone dev flow + # (hack/dev.sh), which builds as the host user, this path builds as root, so + # mark /src safe. Mirrors hack/package-release.sh. + peer_exec "$peer" git config --global --add safe.directory /src # Build binary peer_exec "$peer" make bin/miren # Symlinks