Better GraphQL error logging

Author: alexr00

src/github/githubRepository.ts

@@ -55,7 +55,7 @@ import {
 	User,
 } from './interface';
 import { IssueChangeEvent, IssueModel } from './issueModel';
-import { getErrorCode, LoggingOctokit } from './loggingOctokit';
+import { getErrorCode, GraphQLError, LoggingOctokit } from './loggingOctokit';
 import { PullRequestModel } from './pullRequestModel';
 import defaultSchema from './queries.gql';
 import * as extraSchema from './queriesExtra.gql';
@@ -162,18 +162,6 @@ export interface ForkDetails {
 
 export type IMetadata = OctokitCommon.ReposGetResponseData;
 
-export enum GraphQLErrorType {
-	Unprocessable = 'UNPROCESSABLE',
-}
-
-export interface GraphQLError {
-	extensions?: {
-		code: string;
-	};
-	type?: GraphQLErrorType;
-	message?: string;
-}
-
 export enum CopilotWorkingStatus {
 	NotCopilotIssue = 'NotCopilotIssue',
 	InProgress = 'InProgress',

src/github/loggingOctokit.ts

@@ -28,6 +28,18 @@ interface RateLimitResult {
 	} | undefined;
 }
 
+export enum GraphQLErrorType {
+	Unprocessable = 'UNPROCESSABLE',
+}
+
+export interface GraphQLError {
+	extensions?: {
+		code: string;
+	};
+	type?: GraphQLErrorType;
+	message?: string;
+}
+
 function isObject(value: unknown): value is Record<string, unknown> {
 	return typeof value === 'object' && value !== null;
 }
@@ -47,12 +59,14 @@ export function getErrorCode(e: unknown): string | undefined {
 	}
 
 	const graphQLErrors = e.graphQLErrors;
-	if (Array.isArray(graphQLErrors)) {
-		const firstGraphQLError = graphQLErrors[0];
-		if (isObject(firstGraphQLError)) {
-			const extensions = firstGraphQLError.extensions;
-			if (isObject(extensions) && extensions.code !== undefined) {
-				return String(extensions.code);
+	if (Array.isArray(graphQLErrors) && graphQLErrors.length > 0) {
+		const firstGraphQLError = graphQLErrors[0] as GraphQLError | undefined;
+		if (firstGraphQLError) {
+			if (firstGraphQLError.extensions?.code !== undefined) {
+				return String(firstGraphQLError.extensions.code);
+			}
+			if (firstGraphQLError.type !== undefined) {
+				return String(firstGraphQLError.type);
 			}
 		}
 	}