Skip to content

Commit cea7a72

Browse files
committed
clean up
1 parent 69de40f commit cea7a72

1 file changed

Lines changed: 3 additions & 17 deletions

File tree

  • webviews/createPullRequestViewNew

webviews/createPullRequestViewNew/app.tsx

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -172,22 +172,8 @@ export function main() {
172172
}
173173
}
174174

175-
function openDescriptionSettings(event: React.MouseEvent | React.KeyboardEvent): void {
176-
let shouldExecute = false;
177-
178-
if (event.type === 'keydown') {
179-
const keyEvent = event as React.KeyboardEvent;
180-
if (keyEvent.key === 'Enter' || keyEvent.key === ' ') {
181-
event.preventDefault();
182-
shouldExecute = true;
183-
}
184-
} else if (event.type === 'click') {
185-
shouldExecute = true;
186-
}
187-
188-
if (shouldExecute) {
189-
ctx.postMessage({ command: 'pr.openDescriptionSettings' });
190-
}
175+
function openDescriptionSettings(_event: React.MouseEvent | React.KeyboardEvent): void {
176+
ctx.postMessage({ command: 'pr.openDescriptionSettings' });
191177
}
192178

193179
async function generateTitle(useCopilot?: boolean) {
@@ -345,7 +331,7 @@ export function main() {
345331

346332
<div className='group-description-header'>
347333
<label htmlFor='description' className='input-title'>Description</label>
348-
<button type='button' title='Open pull request description settings' aria-label='Open pull request description settings' className='description-settings-action icon-button' onClick={openDescriptionSettings} onKeyDown={openDescriptionSettings} tabIndex={0}>{settingsIcon}</button>
334+
<a role='button' title='Open pull request description settings' aria-label='Open pull request description settings' className='icon-button' onClick={openDescriptionSettings}>{settingsIcon}</a>
349335
</div>
350336
<div className='group-description'>
351337
<textarea

0 commit comments

Comments
 (0)