Skip to content

Commit 8809568

Browse files
committed
Visual Label not provided for "Title" and "Description" field: A11y_Visual Studio Code Web Extensions_Github Pull request_Create New Request_Labels or Instructions
Fixes #7595
1 parent c991802 commit 8809568

2 files changed

Lines changed: 13 additions & 6 deletions

File tree

webviews/createPullRequestViewNew/app.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ export function main() {
192192
<div className='group-branches'>
193193
<div className='input-label base'>
194194
<div className="deco">
195-
<span title='Base branch' aria-hidden='true'>{prBaseIcon} Base</span>
195+
<span title='Base branch' aria-hidden='true'>{prBaseIcon} BASE</span>
196196
</div>
197197
<ChooseRemoteAndBranch onClick={ctx.changeBaseRemoteAndBranch}
198198
defaultRemote={params.baseRemote}
@@ -205,7 +205,7 @@ export function main() {
205205

206206
<div className='input-label merge'>
207207
<div className="deco">
208-
<span title='Merge branch' aria-hidden='true'>{prMergeIcon} {params.actionDetail ? params.actionDetail : 'Merge'}</span>
208+
<span title='Merge branch' aria-hidden='true'>{prMergeIcon} {params.actionDetail ? params.actionDetail : 'MERGE'}</span>
209209
</div>
210210
{ctx.createParams.canModifyBranches ?
211211
<ChooseRemoteAndBranch onClick={ctx.changeMergeRemoteAndBranch}
@@ -220,6 +220,7 @@ export function main() {
220220
</div>
221221
</div>
222222

223+
<span className='input-title'>TITLE</span>
223224
<div className='group-title'>
224225
<input
225226
id='title'
@@ -325,6 +326,7 @@ export function main() {
325326
: null}
326327
</div>
327328

329+
<span className='input-title'>DESCRIPTION</span>
328330
<div className='group-description'>
329331
<textarea
330332
id='description'

webviews/createPullRequestViewNew/index.css

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ textarea:disabled {
3131

3232
.group-branches {
3333
margin-top: 20px;
34-
margin-bottom: 10px;
34+
margin-bottom: 2px;
3535
}
3636

3737
.input-label.base,
@@ -72,8 +72,7 @@ button.input-box {
7272
.input-label {
7373
display: flex;
7474
align-items: center;
75-
font-variant-caps: all-small-caps;
76-
font-size: small;
75+
font-size: 11px;
7776
margin-bottom: 14px;
7877
}
7978

@@ -86,6 +85,12 @@ button.input-box {
8685

8786
/* Title, Description */
8887

88+
.input-title {
89+
display: block;
90+
font-size: 11px;
91+
margin-bottom: 4px;
92+
}
93+
8994
#title {
9095
padding-right: 24px;
9196
text-overflow: ellipsis;
@@ -95,6 +100,7 @@ button.input-box {
95100
position: relative;
96101
display: flex;
97102
flex-direction: column;
103+
margin-bottom: 12px;
98104
}
99105

100106
.group-title .title-action:hover {
@@ -141,7 +147,6 @@ button.input-box {
141147

142148
.group-description {
143149
flex-grow: 1;
144-
margin-top: 10px;
145150
max-height: 500px;
146151
}
147152

0 commit comments

Comments
 (0)