Use globalState cache in getAssignable/MentionableUsers when fetch promise exists

Copilot · alexr00 · web-flow · commit 32d8519019a3 · 2026-04-28T12:03:36.000Z
Agent-Logs-Url: https://github.com/microsoft/vscode-pull-request-github/sessions/6fa0d829-6819-4faf-8e7c-efa3758b29cd Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
diff --git a/src/github/folderRepositoryManager.ts b/src/github/folderRepositoryManager.ts
@@ -746,7 +746,7 @@ export class FolderRepositoryManager extends Disposable {
 			return globalStateMentionableUsers ?? this._fetchMentionableUsersPromise;
 		}
 
-		return this._fetchMentionableUsersPromise;
+		return globalStateMentionableUsers ?? this._fetchMentionableUsersPromise;
 	}
 
 	async getAssignableUsers(clearCache?: boolean): Promise<{ [key: string]: IAccount[] }> {
@@ -783,7 +783,7 @@ export class FolderRepositoryManager extends Disposable {
 			return globalStateAssignableUsers ?? this._fetchAssignableUsersPromise;
 		}
 
-		return this._fetchAssignableUsersPromise;
+		return globalStateAssignableUsers ?? this._fetchAssignableUsersPromise;
 	}
 
 	async getTeamReviewers(refreshKind: TeamReviewerRefreshKind): Promise<{ [key: string]: ITeam[] }> {

Original file line number	Diff line number	Diff line change
`@@ -746,7 +746,7 @@ export class FolderRepositoryManager extends Disposable {`
`746`	`746`	`return globalStateMentionableUsers ?? this._fetchMentionableUsersPromise;`
`747`	`747`	`}`
`748`	`748`
`749`		`- return this._fetchMentionableUsersPromise;`
	`749`	`+ return globalStateMentionableUsers ?? this._fetchMentionableUsersPromise;`
`750`	`750`	`}`
`751`	`751`
`752`	`752`	`async getAssignableUsers(clearCache?: boolean): Promise<{ [key: string]: IAccount[] }> {`
`@@ -783,7 +783,7 @@ export class FolderRepositoryManager extends Disposable {`
`783`	`783`	`return globalStateAssignableUsers ?? this._fetchAssignableUsersPromise;`
`784`	`784`	`}`
`785`	`785`
`786`		`- return this._fetchAssignableUsersPromise;`
	`786`	`+ return globalStateAssignableUsers ?? this._fetchAssignableUsersPromise;`
`787`	`787`	`}`
`788`	`788`
`789`	`789`	`async getTeamReviewers(refreshKind: TeamReviewerRefreshKind): Promise<{ [key: string]: ITeam[] }> {`