Skip to content

Commit 7397d42

Browse files
author
Seth
committed
AZD - template cleanup, removed env, rebuilt main.json
1 parent 0664594 commit 7397d42

3 files changed

Lines changed: 16 additions & 16 deletions

File tree

.github/workflows/azd-template-validation.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ on:
33
workflow_dispatch:
44
push:
55
branches:
6-
- azd/add-template-gallery
6+
- main
77

88
permissions:
99
contents: read
@@ -13,7 +13,6 @@ permissions:
1313
jobs:
1414
template_validation:
1515
runs-on: ubuntu-latest
16-
environment: azd-template-gallery-seth-mcaps
1716
name: azd template validation
1817
steps:
1918
- uses: actions/checkout@v4
@@ -24,9 +23,9 @@ jobs:
2423
useDevContainer: ${{ vars.TEMPLATE_USE_DEV_CONTAINER }}
2524
id: validation
2625
env:
27-
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
28-
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
29-
AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
26+
AZURE_CLIENT_ID: ${{ vars.AZURE_CLIENT_ID }}
27+
AZURE_TENANT_ID: ${{ vars.AZURE_TENANT_ID }}
28+
AZURE_SUBSCRIPTION_ID: ${{ vars.AZURE_SUBSCRIPTION_ID }}
3029
AZURE_ENV_NAME: ${{ vars.AZURE_ENV_NAME }}
3130
AZURE_LOCATION: ${{ vars.AZURE_LOCATION }}
3231
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/azure-dev.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ on:
33
workflow_dispatch:
44
push:
55
branches:
6-
- azd/add-template-gallery
6+
- main
77

88
permissions:
99
id-token: write
@@ -12,12 +12,11 @@ permissions:
1212
jobs:
1313
build:
1414
runs-on: ubuntu-latest
15-
environment: azd-template-gallery-seth-mcaps
1615
env:
17-
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
18-
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
19-
AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
20-
AZURE_RESOURCE_GROUP: ${{ secrets.AZURE_RESOURCE_GROUP }}
16+
AZURE_CLIENT_ID: ${{ vars.AZURE_CLIENT_ID }}
17+
AZURE_TENANT_ID: ${{ vars.AZURE_TENANT_ID }}
18+
AZURE_SUBSCRIPTION_ID: ${{ vars.AZURE_SUBSCRIPTION_ID }}
19+
AZURE_RESOURCE_GROUP: ${{ vars.AZURE_RESOURCE_GROUP }}
2120
AZURE_ENV_NAME: ${{ vars.AZURE_ENV_NAME }}
2221
AZURE_LOCATION: ${{ vars.AZURE_LOCATION }}
2322
AZURE_USER_OBJECT_ID: ''

infra/main.json

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"_generator": {
77
"name": "bicep",
88
"version": "0.33.93.31351",
9-
"templateHash": "3696806033148817293"
9+
"templateHash": "10384721894949341887"
1010
}
1111
},
1212
"definitions": {
@@ -1684,7 +1684,7 @@
16841684
},
16851685
"vmAdminPasswordOrKey": {
16861686
"type": "securestring",
1687-
"minLength": 8,
1687+
"minLength": 4,
16881688
"maxLength": 70,
16891689
"metadata": {
16901690
"description": "Specifies the password for the jump-box virtual machine. This is necessary to provide secure access to the private VNET via a jump-box VM with Bastion. Value should be meet 3 of the following: uppercase character, lowercase character, numberic digit, special character, and NO control characters."
@@ -22816,7 +22816,7 @@
2281622816
"_generator": {
2281722817
"name": "bicep",
2281822818
"version": "0.33.93.31351",
22819-
"templateHash": "11468708502826403477"
22819+
"templateHash": "10286244752482293080"
2282022820
}
2282122821
},
2282222822
"parameters": {
@@ -22987,13 +22987,15 @@
2298722987
}
2298822988
},
2298922989
"variables": {
22990+
"randomString": "[uniqueString(resourceGroup().id, parameters('vmName'), parameters('vmAdminPasswordOrKey'))]",
22991+
"adminPassword": "[if(less(length(parameters('vmAdminPasswordOrKey')), 8), format('{0}{1}', parameters('vmAdminPasswordOrKey'), take(variables('randomString'), 12)), parameters('vmAdminPasswordOrKey'))]",
2299022992
"linuxConfiguration": {
2299122993
"disablePasswordAuthentication": true,
2299222994
"ssh": {
2299322995
"publicKeys": [
2299422996
{
2299522997
"path": "[format('/home/{0}/.ssh/authorized_keys', parameters('vmAdminUsername'))]",
22996-
"keyData": "[parameters('vmAdminPasswordOrKey')]"
22998+
"keyData": "[variables('adminPassword')]"
2299722999
}
2299823000
]
2299923001
},
@@ -23035,7 +23037,7 @@
2303523037
"osProfile": {
2303623038
"computerName": "[take(parameters('vmName'), 15)]",
2303723039
"adminUsername": "[parameters('vmAdminUsername')]",
23038-
"adminPassword": "[parameters('vmAdminPasswordOrKey')]",
23040+
"adminPassword": "[variables('adminPassword')]",
2303923041
"linuxConfiguration": "[if(equals(parameters('authenticationType'), 'password'), null(), variables('linuxConfiguration'))]"
2304023042
},
2304123043
"storageProfile": {

0 commit comments

Comments
 (0)